Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wiab automation #742

Merged
merged 20 commits into from
Nov 4, 2024
Merged

Fix wiab automation #742

merged 20 commits into from
Nov 4, 2024

Conversation

amitsagtani97
Copy link
Contributor

https://wearezeta.atlassian.net/browse/WPB-11340

Fix the autodeploy script for installing wire-server on fresh vms

@amitsagtani97 amitsagtani97 requested review from julialongtin and a team as code owners October 24, 2024 12:55
jschumacher-wire
jschumacher-wire requested changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@jschumacher-wire jschumacher-wire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Amit, thank you for the fixes! I left a small suggestion.

bin/autodeploy.sh Outdated Show resolved Hide resolved
@jschumacher-wire
Copy link
Contributor

I've added a small check in bin/offline-vm-setup.sh to wait and only exit the script once VM deployment is done. Otherwise, we might kill the small webserver used by cloud-init too early, potentially resulting in failed bootstrap installs for the last few VMs on the list.

Side note - I remember there was discussion regarding where to implement the pipeline, and that Concourse might be preferred. I realize it's not in the ticket, but I wanted to double-check.

@lwille what do you think?

In any case, very good work @amitsagtani97 :)

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@amitsagtani97 amitsagtani97 merged commit e7643e9 into master Nov 4, 2024
5 of 6 checks passed
@amitsagtani97 amitsagtani97 deleted the fix_wiab_automation branch November 4, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschumacher-wire jschumacher-wire jschumacher-wire approved these changes

@julialongtin julialongtin Awaiting requested review from julialongtin julialongtin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amitsagtani97 @jschumacher-wire