Remove restund #740
Open
Remove restund #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
julialongtin
requested changes
Dec 9, 2024
ansible/inventory/offline/99-static
Outdated
| # For the following groups, add all nodes defined above to the sections below. | ||
| # Define any additional variables that should be set for these nodes. | ||
|
|
||
| # Uncomment this is you use the bastion host |
There was a problem hiding this comment.
line 118, 119, and 120 should be kept.
There was a problem hiding this comment.
Added them back
| @@ -70,7 +70,6 @@ fi | |||
| if [[ ! -f $ANSIBLE_DIR/inventory/offline/group_vars/all/secrets.yaml ]]; then | |||
| echo "Writing $ANSIBLE_DIR/inventory/offline/group_vars/all/secrets.yaml" | |||
| cat << EOT > $ANSIBLE_DIR/inventory/offline/group_vars/all/secrets.yaml | |||
| restund_zrest_secret: "$zrest" | |||
There was a problem hiding this comment.
don't we still need a zrest secret for coturn?
There was a problem hiding this comment.
We are directly setting it here -
brig:
secrets:
smtpPassword: dummyPassword
zAuth:
publicKeys: "$zauth_public"
privateKeys: "$zauth_private"
turn:
secret: "$zrest"
| and enable the ports for colocated services running on these nodes: | ||
|
|
||
| ``` | ||
| sudo bash -c ' |
There was a problem hiding this comment.
we should do something to preserve this list?
There was a problem hiding this comment.
added them back
amitsagtani97
force-pushed
the
remove_restund
branch
from
177ddfa to
3535c89
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-11483