Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wpb 10872 | Update docs to always deploy RabbitMQ and add data persistence #730

Merged
merged 6 commits into from
Sep 10, 2024
Merged

Wpb 10872 | Update docs to always deploy RabbitMQ and add data persistence #730

merged 6 commits into from
Sep 10, 2024

Conversation

amitsagtani97
Copy link
Contributor

@jschumacher-wire
Copy link
Contributor

Looks good!

One question - how does backup & restore work with the helm deployment of RabbitMQ?

@amitsagtani97
Copy link
Contributor Author

Looks good!

One question - how does backup & restore work with the helm deployment of RabbitMQ?

We do not have any specific backup/restore procedure for RabbitMQ in k8s, I have added the reference to the official docs from Openebs to backup/restore the provisioned volumes.

@jschumacher-wire
Copy link
Contributor

Looks good!
One question - how does backup & restore work with the helm deployment of RabbitMQ?

We do not have any specific backup/restore procedure for RabbitMQ in k8s, I have added the reference to the official docs from Openebs to backup/restore the provisioned volumes.

Ah, I did not see that link. Makes sense not to duplicate upstream documentation.

LGTM!

@jschumacher-wire jschumacher-wire self-requested a review September 9, 2024 09:17
julialongtin
julialongtin approved these changes Sep 10, 2024
View reviewed changes
offline/rabbitmq_setup.md Outdated Show resolved Hide resolved
offline/rabbitmq_setup.md Outdated Show resolved Hide resolved
offline/rabbitmq_setup.md Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@amitsagtani97 amitsagtani97 merged commit 3f096d1 into master Sep 10, 2024
5 of 6 checks passed
@amitsagtani97 amitsagtani97 deleted the wpb-10872 branch September 10, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschumacher-wire jschumacher-wire jschumacher-wire approved these changes

@julialongtin julialongtin julialongtin approved these changes

@arthurwolf arthurwolf Awaiting requested review from arthurwolf

Assignees
No one assigned
Labels
echoes/initiative: personal-users-to-team-users...
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amitsagtani97 @jschumacher-wire @julialongtin