Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce more automation for dedicated Hetzner server deployments prior to kubespray upgrades #676

Merged
merged 8 commits into from
Jan 24, 2024

Conversation

jschumacher-wire
Copy link
Contributor

WPB-2324

Introduction of ansible playbook for Hetzner server bootstrapping; more automation for offline-vm-setup.sh

@CLAassistant
Copy link

CLAassistant commented Jan 17, 2024

CLA assistant check
All committers have signed the CLA.

vars:
artifact_hash: a6e0929c9a5f4af09655c9433bb56a4858ec7574
ubuntu_version: 22.04.3
ssh_pubkey: "ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIODDzgw4BncNvSVOIraAXZYkkLn+iTo6ixkXXQ4lKZhL [email protected]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be your personal public key?

vars:
artifact_hash: a6e0929c9a5f4af09655c9433bb56a4858ec7574
ubuntu_version: 22.04.3
ssh_pubkey: "ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIODDzgw4BncNvSVOIraAXZYkkLn+iTo6ixkXXQ4lKZhL [email protected]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might want to just change the key comment here and consider not using a valid key. i am sure a user might accidentally copy this one day :)

Copy link
Contributor

@julialongtin julialongtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall, this looks like serious progress.

Copy link
Contributor

@supersven supersven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused why we're adding comments to commits instead of reviews... However, please take this into account: 7210a70#r137355832

…-setup.sh using static IPs and SSH key management, Readme updates, playbook fixes
ansible/files/hetzner_server_nftables.conf Show resolved Hide resolved
SSHKEY_DEMO=$(cat "$HOME"/.ssh/id_ed25519.pub)
fi

msg ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, how do we get our 'usual' key from 1password into this?

bin/offline-vm-setup.sh Outdated Show resolved Hide resolved
name="$2"
create_assethost "$name"
fi
msg "Creating VM ""${VM_NAME[i]}"" with IP ""${VM_IP[i]}"" ..."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have to set this up again, we're going to have a LOT of duplicate entries in /etc/hosts


Note: If you are using a Hetzner machine, docker should already be installed (you can check with `docker version`) and you can skip this section.
This section is a continuation of the demo cluster setup described in single_hetzner_machine_installation.md. At this point, the following prerequisites should be met:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This document is certanly not a continuation: THIS IS WHERE CUSTOMERS START.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EG: in a customer deployment, we point them to this document, and follow along with them, or they follow along with us.

offline/single_hetzner_machine_installation.md Outdated Show resolved Hide resolved
offline/single_hetzner_machine_installation.md Outdated Show resolved Hide resolved
## disable internet access to the vms

Replace all of ntftables.conf
VMs created with offline-vm-setup.sh are accessible via SSH with two public keys.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might want to say where they're accessable from.

jschumacher-wire and others added 2 commits January 23, 2024 11:10
…or ingress forwarding; adding more logic to offline-vm-deploy script; updating SSH pubkey to make use of existing infrastructure key
@jschumacher-wire jschumacher-wire removed the request for review from amitsagtani97 January 24, 2024 15:55
@jschumacher-wire jschumacher-wire merged commit 452c8d4 into master Jan 24, 2024
3 of 4 checks passed
@jschumacher-wire jschumacher-wire deleted the hetzner_single_deployment_automation branch January 24, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants