Bump kubernetes to v1.28.2 #675
Conversation
amitsagtani97
force-pushed
the
bump_kubernetes_to_1_28
branch
7 times, most recently
from
68ade72 to
8ecfb23
Compare
amitsagtani97
force-pushed
the
bump_kubernetes_to_1_28
branch
3 times, most recently
from
817599c to
5c7a4f4
Compare
amitsagtani97
force-pushed
the
bump_kubernetes_to_1_28
branch
2 times, most recently
from
3acc9f0 to
58a6f1f
Compare
amitsagtani97
force-pushed
the
bump_kubernetes_to_1_28
branch
from
58a6f1f to
e7e2e6a
Compare
| ansible-playbook -i $INVENTORY_FILE $ANSIBLE_DIR/kubernetes.yml --skip-tags bootstrap-os,preinstall,container-engine | ||
|
|
||
| ./bin/fix_default_router.sh | ||
| ansible-playbook -i $INVENTORY_FILE $ANSIBLE_DIR/kubernetes.yml --skip-tags bootstrap-os,preinstall,container-engine,multus |
There was a problem hiding this comment.
@julialongtin I'm surprised as you are, but there are traces of multus in our code base: https://github.com/kubernetes-sigs/kubespray/blob//docs/multus.md?plain=1#L1
Me needs a scratches-head emoji.
There was a problem hiding this comment.
this multus network plugin playbooks were being run while installing k8s, even the variable to install multus was set to false and was throwing some dependency issues, hence added that tag in the skip list
offline/ci.sh
Outdated
|
|
||
| # TODO: Awaiting some fixes in wire-server regarding tagless images | ||
| HELM_HOME=$(mktemp -d) | ||
| export HELM_HOME | ||
|
|
||
| helm repo add wire https://s3-eu-west-1.amazonaws.com/public.wire.com/charts | ||
| helm repo add wire https://s3-eu-west-1.amazonaws.com/public.wire.com/charts-develop |
There was a problem hiding this comment.
aha. this is smart. rewrite this file a bit, so this is the way we do this now?
There was a problem hiding this comment.
The clean solution would be to extract parameters for the parts that depend on the version. And, fill with with what we get from Stefan M.'s build.json files: https://github.com/wireapp/wire-builds/blob/108f7eb93bc6d1227f04c23032fab0c58390e5fe/build.json
This refactoring doesn't have to be done now. However, it's good to keep in mind that this changing of versions / Helm repos buried deep inside some files is neither the goal nor the future.
There was a problem hiding this comment.
this was temporary change to test the changes needed in helm charts for k8s 1.28
Goal is to use the build.json later.
offline/ci.sh
Outdated
| @@ -101,16 +116,16 @@ calling_charts=( | |||
| ) | |||
|
|
|||
| # wire_version=$(helm show chart wire/wire-server | yq -r .version) | |||
| wire_version="4.39.0" | |||
| wire_version="4.39.159" | |||
There was a problem hiding this comment.
Hm, so the version that is currently on staging will be the version that our users should install? Was this an active choice by someone? 🤔
Or, will this branch not be merged to master?
There was a problem hiding this comment.
there were changes needed in the wire-server helm chart to support k8s 1.28
This change is temporary, goal is to replace it with "4.40" as soon as that is released and than merge
This reverts commit 6863399.
amitsagtani97
force-pushed
the
bump_kubernetes_to_1_28
branch
from
2773f72 to
3d51c4c
Compare
wpb-2324
This pr adds dependencies for deploying kubernetes v1.28.2 by default, with latest kubespray version.