Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove ubuntu 18 support #662

Merged
merged 5 commits into from
Nov 6, 2023
Merged

remove ubuntu 18 support #662

merged 5 commits into from
Nov 6, 2023

Conversation

amitsagtani97
Copy link
Contributor

Remove the support for ubuntu 18 based wire-server deployment in offline env.

#WPB-4880

@amitsagtani97 amitsagtani97 force-pushed the remove_ubuntu_18_support branch 2 times, most recently from 8b89de5 to f4b48ac Compare October 13, 2023 21:26
@amitsagtani97 amitsagtani97 force-pushed the remove_ubuntu_18_support branch from f4b48ac to 7c1a782 Compare October 13, 2023 21:34
@julialongtin
Copy link
Contributor

This removes the mechanics, but does not remove any of the documentation. can we verify that everything of import from the old documentation has been merged, and then remove it with this PR, as well?

@supersven
Copy link
Contributor

This removes the mechanics, but does not remove any of the documentation. can we verify that everything of import from the old documentation has been merged, and then remove it with this PR, as well?

Adding to this: IMHO it would also be good to rename the existing offline/ubuntu22.04_installation.md to communicate that it is about a very specific setup; namely single Hetzner machine with KVM. (I like the name single_hetzner_machine_installation.md, but others may be even better.)

@amitsagtani97
Copy link
Contributor Author

Moved the restund firewall fixes docs and renamed the file to single_hetzner_machine_installation.md :)

@amitsagtani97 amitsagtani97 merged commit bc1cbd2 into master Nov 6, 2023
3 checks passed
@amitsagtani97 amitsagtani97 deleted the remove_ubuntu_18_support branch November 6, 2023 16:13
@arthurwolf
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julialongtin julialongtin julialongtin approved these changes

@supersven supersven Awaiting requested review from supersven

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amitsagtani97 @julialongtin @supersven @arthurwolf