Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: back port general mls fixes - 4.6 (WPB-15040) #3793

Merged
merged 5 commits into from
Jan 9, 2025

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Jan 9, 2025

BugWPB-15040 [Android] Display cipher suite on MLS device details


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Backport fixes to 4.6 branch

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Jan 9, 2025
@yamilmedina yamilmedina requested review from Garzas and ohassine January 9, 2025 16:40
@yamilmedina yamilmedina enabled auto-merge (squash) January 9, 2025 16:40
@yamilmedina yamilmedina changed the title fix: back port general mls fixes (WPB-15040) fix: back port general mls fixes - 4.6 (WPB-15040) Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Test Results

863 tests   862 ✅  13m 46s ⏱️
119 suites    0 💤
119 files      1 ❌

For more details on these failures, see this check.

Results for commit b2404af.

Copy link

sonarqubecloud bot commented Jan 9, 2025

@yamilmedina yamilmedina merged commit bef00f6 into release/cycle-4.6 Jan 9, 2025
11 of 14 checks passed
@yamilmedina yamilmedina deleted the fix/port-general-mls-fixes branch January 9, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT CHERRY PICK echoes: unplanned Any work item that isn’t part of the product or technical roadmap. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants