Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reappearing keyboard [WPB-10889] #3791

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Jan 8, 2025

BugWPB-10889 [Android] MLS Migration opens keyboard


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When message composer input still has focus but the keyboard is closed, after making some actions, the keyboard reappears.

Causes (Optional)

onFocusChanged was being called only when the input received focus, but not when focus was freed, but the logic behind that lambda in MessageComposerStateHolder.onInputFocusedChanged needs to be called in both cases to request or clear focus properly.

Solutions

Cakk onFocusChanged in both cases, when the input gets the focus and when loses it. Also, free the focus when it's not needed anymore.

Testing

How to Test

Open group conversation, click on a message input to get focus, close the keyboard, open conversation details and go back - keyboard should not reappear.

Attachments (Optional)

Before After
keyboard_reappears_before.mp4
keyboard_reappears_after.mp4

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Test Results

863 tests   863 ✅  17m 0s ⏱️
119 suites    0 💤
119 files      0 ❌

Results for commit 5ae039a.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 8, 2025

APKs built during tests are available here. Scroll down to Artifacts!

@saleniuk saleniuk requested review from a team, m-zagorski, yamilmedina, alexandreferris, borichellow and Garzas and removed request for a team January 8, 2025 17:06
@echoes-hq echoes-hq bot added the echoes: unplanned/incident Work items addressing critical product defects that require immediate action, such as bugs, platf... label Jan 10, 2025
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@saleniuk saleniuk merged commit c9e1e24 into release/cycle-4.6 Jan 10, 2025
14 checks passed
@saleniuk saleniuk deleted the fix/reappearing-keyboard branch January 10, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned/incident Work items addressing critical product defects that require immediate action, such as bugs, platf... size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants