fix: reappearing keyboard [WPB-10889] #3791
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
When message composer input still has focus but the keyboard is closed, after making some actions, the keyboard reappears.
Causes (Optional)
onFocusChanged
was being called only when the input received focus, but not when focus was freed, but the logic behind that lambda inMessageComposerStateHolder.onInputFocusedChanged
needs to be called in both cases to request or clear focus properly.Solutions
Cakk
onFocusChanged
in both cases, when the input gets the focus and when loses it. Also, free the focus when it's not needed anymore.Testing
How to Test
Open group conversation, click on a message input to get focus, close the keyboard, open conversation details and go back - keyboard should not reappear.
Attachments (Optional)
keyboard_reappears_before.mp4
keyboard_reappears_after.mp4
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.