Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate from hilt-android-compiler to hilt-compiler (WPB-8645) #3789

Merged

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Jan 7, 2025

EpicWPB-8645 [Android] Infrastructure code and developer experience


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

The hilt-android-compiler artifact will be deprecated in a future release.

https://github.com/google/dagger/releases/tag/dagger-2.29.1

The hilt-compiler artifact is just a rename of hilt-android-compiler. The motivation here is to have a single compiler artifact that works with both Android and non-Android libraries. The hilt-android-compiler artifact will be deprecated in a future release, so please migrate to hilt-compiler.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, m-zagorski, alexandreferris, borichellow, MohamadJaara and mathias-niboulies and removed request for a team January 7, 2025 14:11
Copy link

sonarqubecloud bot commented Jan 7, 2025

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Built wire-android-staging-compat-pr-3789.apk is available for download

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Built wire-android-dev-debug-pr-3789.apk is available for download

@ohassine ohassine added this pull request to the merge queue Jan 8, 2025
Merged via the queue into develop with commit f45ed9e Jan 8, 2025
12 checks passed
@ohassine ohassine deleted the Migrate-from-hilt-android-compiler-to-hilt-compiler branch January 8, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants