Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update s3 config to adjust to private (WPB-8645) #3784

Merged
merged 4 commits into from
Jan 6, 2025

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Jan 3, 2025

EpicWPB-8645 [Android] Infrastructure code and developer experience


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

adjustments for s3 new configs needs to be performed

Causes (Optional)

s3 uploads are failing

Solutions

mark as private to be the same as the bucket config


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina changed the title ci: update s2 config to adjust to private (WPB-8645) ci: update s3 config to adjust to private (WPB-8645) Jan 3, 2025
@yamilmedina yamilmedina enabled auto-merge January 3, 2025 15:46
@wireapp wireapp deleted a comment from github-actions bot Jan 6, 2025
@wireapp wireapp deleted a comment from github-actions bot Jan 6, 2025
@wireapp wireapp deleted a comment from github-actions bot Jan 6, 2025
@wireapp wireapp deleted a comment from github-actions bot Jan 6, 2025
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Built wire-android-staging-compat-pr-3784.apk is available for download

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Built wire-android-dev-debug-pr-3784.apk is available for download

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.80%. Comparing base (4883d0e) to head (29eb11f).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3784   +/-   ##
========================================
  Coverage    45.80%   45.80%           
========================================
  Files          483      483           
  Lines        16513    16513           
  Branches      2783     2783           
========================================
  Hits          7563     7563           
  Misses        8170     8170           
  Partials       780      780           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4883d0e...29eb11f. Read the comment docs.

Copy link

sonarqubecloud bot commented Jan 6, 2025

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Built wire-android-staging-compat-pr-3784.apk is available for download

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Built wire-android-dev-debug-pr-3784.apk is available for download

@yamilmedina yamilmedina added this pull request to the merge queue Jan 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 6, 2025
@yamilmedina yamilmedina added this pull request to the merge queue Jan 6, 2025
Merged via the queue into develop with commit 9d5c57c Jan 6, 2025
12 of 13 checks passed
@yamilmedina yamilmedina deleted the ci/adjust-s3bucket-configs branch January 6, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants