Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: condition not needed for protocol display in group conversation (WPB-15205) #3775

Merged

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Dec 30, 2024

TaskWPB-15205 [Android] conv protocol is not visible for Proteus in RC


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Missing condition slipped that didn't allow protocol info be displayed in proteus conversations

Solutions

Fix it

Attachments (Optional)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Dec 30, 2024
@yamilmedina yamilmedina added this pull request to the merge queue Dec 30, 2024
Copy link
Contributor

Built wire-android-staging-compat-pr-3775.apk is available for download

Merged via the queue into release/candidate with commit 41d14bf Dec 30, 2024
14 of 15 checks passed
@yamilmedina yamilmedina deleted the fix/display-protocol-on-groupsettings branch December 30, 2024 14:13
github-actions bot pushed a commit that referenced this pull request Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants