Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cant see my video from other client [#WPB-12179] #3773

Closed
wants to merge 1 commit into from

Conversation

m-zagorski
Copy link
Contributor

https://wearezeta.atlassian.net/browse/WPB-12179

What's new in this PR?

Issues

We were unable to see our own preview from other client

Solutions

We were marking all our users as owners, which do not support this feature. We need to mark only one participant as owner per call on a device, to allow that we not only have to check out for the id, we also need to make sure client id match.

Dependencies (Optional)

We need this one first wireapp/kalium#3201

Testing

How to Test

  • Have two accounts A and B
  • Use account A on web and android
  • Use account B on either web/android
  • Create group call join with all 3 instances, twice with client A and once with client B
  • Start sharing screen from client A on web
  • You should see client A sharing content on client A on mobile - in both PiP and non PiP modes

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Dec 30, 2024
@m-zagorski m-zagorski closed this Dec 30, 2024
@echoes-hq echoes-hq bot added echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. and removed echoes: unplanned Any work item that isn’t part of the product or technical roadmap. labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant