fix: call controls visibility after closing PiP mode [#WPB-15142] #3770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yamilmedina
approved these changes
Dec 27, 2024
|
Built wire-android-staging-compat-pr-3770.apk is available for download |
|
Built wire-android-dev-debug-pr-3770.apk is available for download |
m-zagorski
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-15142
What's new in this PR?
Issues
Call controls are not visible when returning to the application after closing picture-in-picture mode.
Causes (Optional)
The picture-in-picture activity mode stored in the activity is read directly from the compose code. So the changes in the
picture-in-picture mode are not causing recomposition and app keeps hiding call controls after closing the picture-in-picture mode.
Solutions
Observe picture-in-picture activity mode from compose and store value in compose state.