fix: group protocol info is not shown when it is Proteus [WPB-15205] #3769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes: unplanned
MohamadJaara
commented
Dec 24, 2024
Comment on lines
+190
to
+193
| ProtocolDetails( | ||
| label = UIText.StringResource(R.string.protocol), | ||
| text = UIText.DynamicString(protocolInfo.name()) | ||
| ) |
There was a problem hiding this comment.
the protocol name should be displayed regardless
|
|
Built wire-android-staging-compat-pr-3769.apk is available for download |
yamilmedina
approved these changes
Dec 24, 2024
sergeibakhtiarov
approved these changes
Dec 27, 2024
yamilmedina
deleted the
fix/protocol-details-not-showen-when-it-is-proteus
branch
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
group protocol info is not shown when it is Proteus
Solutions
caused by removing an or condition with compile time flag for MLS
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.