-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adjustments for short signature names (WPB-15188) #3768
fix: adjustments for short signature names (WPB-15188) #3768
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3768 +/- ##
=====================================================
- Coverage 45.69% 45.69% -0.01%
=====================================================
Files 473 473
Lines 16108 16115 +7
Branches 2718 2724 +6
=====================================================
+ Hits 7361 7363 +2
Misses 7986 7986
- Partials 761 766 +5
Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3768.apk is available for download |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
We show now the ciphersuite entry in device details. But currently we show the full string.
We should trim it, to make it easy for the users.
Causes (Optional)
Not previous alignment on this full vs. short name.
Solutions
Implement following suit of what was implemented on other platforms.
I.e.:
Testing
Test Coverage (Optional)
How to Test
Have a MLS client and see on device details the signature
Attachments (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.