Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjustments for short signature names (WPB-15188) #3768

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Dec 24, 2024

BugWPB-15188 [Android] Trim ciphersuite entry on device details


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We show now the ciphersuite entry in device details. But currently we show the full string.
We should trim it, to make it easy for the users.

Causes (Optional)

Not previous alignment on this full vs. short name.

Solutions

Implement following suit of what was implemented on other platforms.
I.e.:

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Have a MLS client and see on device details the signature

Attachments (Optional)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina changed the title fix: adjustments for short signature name fix: adjustments for short signature name Dec 24, 2024
@yamilmedina yamilmedina changed the title fix: adjustments for short signature name fix: adjustments for short signature name (WPB-15188) Dec 24, 2024
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Dec 24, 2024
@yamilmedina yamilmedina changed the title fix: adjustments for short signature name (WPB-15188) fix: adjustments for short signature names (WPB-15188) Dec 24, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 45.69%. Comparing base (6bd0ce4) to head (1a8a42a).

Files with missing lines Patch % Lines
...roid/ui/settings/devices/DeviceDetailsViewModel.kt 37.50% 0 Missing and 5 partials ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #3768      +/-   ##
=====================================================
- Coverage              45.69%   45.69%   -0.01%     
=====================================================
  Files                    473      473              
  Lines                  16108    16115       +7     
  Branches                2718     2724       +6     
=====================================================
+ Hits                    7361     7363       +2     
  Misses                  7986     7986              
- Partials                 761      766       +5     
Files with missing lines Coverage Δ
...roid/ui/settings/devices/DeviceDetailsViewModel.kt 65.35% <37.50%> (-2.15%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bd0ce4...1a8a42a. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3768.apk is available for download

@yamilmedina yamilmedina added this pull request to the merge queue Dec 27, 2024
Merged via the queue into release/candidate with commit 1d22fb4 Dec 27, 2024
26 of 29 checks passed
@yamilmedina yamilmedina deleted the fix/alginement-ciphersuite-display branch December 27, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants