Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Audio message play in background WPB-11725 #3766

Open
wants to merge 25 commits into
base: develop
Choose a base branch
from
Open

feat: Audio message play in background WPB-11725 #3766

wants to merge 25 commits into from

Conversation

borichellow
Copy link
Contributor

@borichellow borichellow commented Dec 23, 2024 •
edited by github-actions bot
Loading

StoryWPB-11725 [Android] Playback improvement - 2 - Auto playback/Background play

this is the first PR from 2, next is coming soon and will be merged into this branch.

What's new in this PR?

  1. Audio message could be played even when user leave conversation screen
  2. When audio message ended the next audio message in conversation (if exist) starts automatically, without any actions from user side
  3. Audio control buttons in ConversationItem in ConversationsList screen.

Attachments (Optional)

Screenshot 2024-12-23 at 12 25 04

@borichellow
feat: Audio messages new design
88a706f
@borichellow
Merge branch 'develop' into feat/audio_messages_new_design
25b582b
@borichellow
Work in progress
3ffc762
@borichellow
Merge branch 'develop' into feat/audio_messages_new_design
3ff7627
@borichellow
Audio messages new design almost ready
0e0f03e
@borichellow
Merge branch 'develop' into feat/audio_messages_new_design
601ce01
@borichellow
Merge branch 'develop' into feat/audio_messages_new_design
0e2dd74
@borichellow
Fixed code style
c79f7ef
@borichellow
Fixed code style and some tests
15f3303
@borichellow
Fix tests
e9ef69c
@borichellow
Updated tests
182d04e
@borichellow
Merge branch 'develop' into feat/audio_messages_new_design
7260a2b
@borichellow
Code style fixes
a8ae13c
@borichellow
Merge branch 'develop' into feat/audio_messages_new_design
49c749c
@borichellow
Added JumpToPlayingAudio Button
b1862e8
@borichellow
Merge branch 'develop' into feat/audio_messages_new_design
9add5f4
@borichellow
finished JumpToPlayingAudioButton
5fee401
@borichellow
Merge branch 'develop' into feat/audio_messages_new_design
c8149dc
@borichellow
Review updates
6ceb9b2
@borichellow
Code style fix
6c29136
@borichellow
feat: Audio message play in background
4be2efe
@borichellow borichellow self-assigned this Dec 23, 2024
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Dec 23, 2024
Base automatically changed from feat/audio_messages_new_design to develop December 27, 2024 14:06
@pull-request-size Pull Request Size
Copy link

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeibakhtiarov sergeibakhtiarov sergeibakhtiarov approved these changes

@saleniuk saleniuk Awaiting requested review from saleniuk

@Garzas Garzas Awaiting requested review from Garzas

@yamilmedina yamilmedina Awaiting requested review from yamilmedina

At least 2 approving reviews are required to merge this pull request.

Assignees

@borichellow borichellow

Labels
DO NOT MERGE echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@borichellow @sergeibakhtiarov