Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: attachments menu blends with background [WPB-15102] #3761

Merged
merged 5 commits into from
Dec 20, 2024

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Dec 19, 2024

BugWPB-15102 [Android] File sharing overlay matches background color of conversation in dark mode


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Attachments menu matches the background color of the conversation screen, making it difficult to distinguish the overlay from the background.

Solutions

Rearrange some surface colors, add border to the attachments menu in the way so that it is drawn properly even during animations.

Testing

How to Test

Open attachments menu on light and dark mode.

Attachments (Optional)

Before After
animation_10x_slower.mp4

@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Dec 19, 2024
@saleniuk saleniuk requested review from Garzas, a team, m-zagorski, yamilmedina, borichellow and mathias-niboulies and removed request for a team December 19, 2024 17:27
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 45.69%. Comparing base (8792a6c) to head (3a06393).
Report is 1 commits behind head on release/candidate.

Files with missing lines Patch % Lines
.../ui/home/messagecomposer/EnabledMessageComposer.kt 0.00% 14 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #3761      +/-   ##
=====================================================
- Coverage              45.73%   45.69%   -0.04%     
=====================================================
  Files                    473      473              
  Lines                  16094    16108      +14     
  Branches                2717     2718       +1     
=====================================================
  Hits                    7361     7361              
- Misses                  7972     7986      +14     
  Partials                 761      761              
Files with missing lines Coverage Δ
...alling/ongoing/participantsview/ParticipantTile.kt 0.00% <ø> (ø)
.../ui/home/messagecomposer/EnabledMessageComposer.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8792a6c...3a06393. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3761.apk is available for download

@saleniuk saleniuk added this pull request to the merge queue Dec 20, 2024
Merged via the queue into release/candidate with commit 6bd0ce4 Dec 20, 2024
13 of 14 checks passed
@saleniuk saleniuk deleted the fix/attachments_menu_blends_with_bg branch December 20, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants