-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: attachments menu blends with background [WPB-15102] #3761
fix: attachments menu blends with background [WPB-15102] #3761
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3761 +/- ##
=====================================================
- Coverage 45.73% 45.69% -0.04%
=====================================================
Files 473 473
Lines 16094 16108 +14
Branches 2717 2718 +1
=====================================================
Hits 7361 7361
- Misses 7972 7986 +14
Partials 761 761
Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3761.apk is available for download |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Attachments menu matches the background color of the conversation screen, making it difficult to distinguish the overlay from the background.
Solutions
Rearrange some surface colors, add border to the attachments menu in the way so that it is drawn properly even during animations.
Testing
How to Test
Open attachments menu on light and dark mode.
Attachments (Optional)
animation_10x_slower.mp4