fix: reusing PagingData crash [WPB-15055][WPB-15079][WPB-15064] #3758
+209
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes: unplanned
|
|
Built wire-android-staging-compat-pr-3758.apk is available for download |
saleniuk
requested review from
a team,
typfel,
alexandreferris,
MohamadJaara,
Garzas and
ohassine
and removed request for
a team
borichellow
approved these changes
Dec 23, 2024
Comment on lines
+231
to
+238
| private fun observeSelfUserLegalHoldState() { | ||
| viewModelScope.launch { | ||
| observeLegalHoldStateForSelfUser() | ||
| .map { it is LegalHoldStateForSelfUser.Enabled } | ||
| .flowOn(dispatcher.io()) | ||
| .collect { isSelfUserUnderLegalHoldFlow.emit(it) } | ||
| } | ||
| } |
There was a problem hiding this comment.
Instead of having a separate fun with collect you can have:
val isSelfUserUnderLegalHoldFlow = observeLegalHoldStateForSelfUser()
.map { it is LegalHoldStateForSelfUser.Enabled }
.flowOn(dispatcher.io())
.shareIn(viewModelScope, SharingStarted.WhileSubscribed(), 1)
yamilmedina
approved these changes
Dec 23, 2024
| isSearchActive = it[0], | ||
| searchQueryTextState = searchQueryTextState | ||
| isSearchActive = it[0] as Boolean, | ||
| searchQueryTextState = it[1]?.let { |
There was a problem hiding this comment.
Question: Are there chances of getting an IndexOutOfBounds here ? Asking just in case we can make it safer (for example using a Pair instead of a List?), otherwise it looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
There are crashes related to reusing
PagingDataflow when doing some actions on paginated conversation list screen, like accepting legal hold request, answering 1:1 call or opening pending connection request which can fetch user data.Causes (Optional)
Each action that modifies (or even puts the same exact data but just requires executing insert, update or delete query) a table that then affects paginated conversation list query, makes this query dirty and executes it again, which reloads the list.
When using
combine, it creates a new instance of flow, so if thecombineis used afterPagingDatais created then if the data is changed and emitted by the flow that's combined, it will re-use the samePagingDataand put it into a new flow, socachedInwon't cache the flow properly and it will crash becausePagingDatacannot be used twice.Solutions
Move
combine"above" thePagingDataflow so that each time a new value is emitted, it will always create a newPagingDatafor the new flow and alsocachedInwill be used correctly.Make use of changes in kalium that doesn't execute upsert queries for User and Client if actually there's no new data so that it doesn't notify other queries - in this case paginated conversation list query thus the query doesn't get dirty and doesn't need to be executed again.
Simplify
showLoadingparameter to be a simple logical equation rather than a state. Make use of mockedpreviewConversationFoldersFlowwith properLoadStatesto represent loaded data instead of using specificinitiallyLoadedparameter.Fix
rememberSearchbarStateso that it actually saves thesearchQueryTextState.Dependencies (Optional)
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
The crash was happening when opening pending connection request (most frequently), answering 1:1 call or accepting legal hold request, so these actions shouldn't crash the app. Also, after opening connection request or 1:1 conversation, if your or that user's data hasn't changed since the last fetch, then it shouldn't refresh the conversation list when navigating back.
Attachments (Optional)
refreshing_when_going_back.mp4
no_refreshing_when_going_back.mp4
pagination_crash.mp4
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.