feat: Track ended call segmentation [#WPB-14256] #3756
Conversation
echoes-hq
bot
added
the
echoes/initiative: product-metrics-in-countly
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3756 +/- ##
===========================================
- Coverage 45.76% 45.74% -0.02%
===========================================
Files 477 477
Lines 16199 16209 +10
Branches 2744 2746 +2
===========================================
+ Hits 7413 7415 +2
- Misses 8017 8024 +7
- Partials 769 770 +1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
Built wire-android-staging-compat-pr-3756.apk is available for download |
|
Built wire-android-dev-debug-pr-3756.apk is available for download |
app/src/main/kotlin/com/wire/android/ui/WireActivityViewModel.kt
Outdated
Show resolved
Hide resolved
core/analytics/src/main/kotlin/com/wire/android/feature/analytics/model/AnalyticsEvent.kt
Outdated
Show resolved
Hide resolved
|
Built wire-android-staging-compat-pr-3756.apk is available for download |
|
Built wire-android-dev-debug-pr-3756.apk is available for download |
| coreLogic.get().getGlobalScope().session.currentSessionFlow().collectLatest { sessionResult -> | ||
| if (sessionResult is CurrentSessionResult.Success && sessionResult.accountInfo.isValid()) { | ||
| coreLogic.get().getSessionScope(sessionResult.accountInfo.userId).calls.observeRecentlyEndedCallMetadata() | ||
| .collect { metadata -> |
There was a problem hiding this comment.
I don't remember why exactly, but i remember we should avoid collect{ flow.collect { } } pattern. Much better to use flatMap, flatMapLatest...
There was a problem hiding this comment.
ah I got you now, you are right! changing it up
There was a problem hiding this comment.
@borichellow you can check it now :)
|
|
Built wire-android-staging-compat-pr-3756.apk is available for download |
|
Built wire-android-dev-debug-pr-3756.apk is available for download |
https://wearezeta.atlassian.net/browse/WPB-14256
What's new in this PR?
Issues
Missing tracking for ended call.
Solutions
Map
RecentlyEndedCallMetadatainto the analytics segmentation and send the event to countlyPR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.