Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add option to manage team [#WPB-14873] #3753

Merged
merged 6 commits into from
Dec 18, 2024

Conversation

m-zagorski
Copy link
Contributor

@m-zagorski m-zagorski commented Dec 17, 2024

TaskWPB-14873 [Android] No access to team management from application

https://wearezeta.atlassian.net/browse/WPB-14873

What's new in this PR?

Issues

There was no option to manage a team

Solutions

Add button for group admins and owners to redirect to a team web page


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Dec 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.76%. Comparing base (e0e5c8b) to head (df6a47b).

Files with missing lines Patch % Lines
...id/ui/userprofile/self/SelfUserProfileViewModel.kt 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3753   +/-   ##
========================================
  Coverage    45.76%   45.76%           
========================================
  Files          477      477           
  Lines        16199    16202    +3     
  Branches      2744     2745    +1     
========================================
+ Hits          7413     7415    +2     
  Misses        8017     8017           
- Partials       769      770    +1     
Files with missing lines Coverage Δ
...ndroid/ui/userprofile/self/SelfUserProfileState.kt 100.00% <100.00%> (ø)
...id/ui/userprofile/self/SelfUserProfileViewModel.kt 56.83% <66.66%> (-0.10%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0e5c8b...df6a47b. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3753.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3753.apk is available for download

@m-zagorski
Copy link
Contributor Author

Looks like the use case for team url is not provided correctly - I will need a small pr for this one

Copy link
Contributor

Built wire-android-staging-compat-pr-3753.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3753.apk is available for download

@m-zagorski m-zagorski added this pull request to the merge queue Dec 18, 2024
Merged via the queue into develop with commit 22a0b22 Dec 18, 2024
13 of 14 checks passed
@m-zagorski m-zagorski deleted the feat/add-option-to-manage-team branch December 18, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants