Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retain filters and simplify navigation [WPB-14518] #3737

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Dec 12, 2024

TaskWPB-14518 Filter not retained after navigating to another screen/Correct colors on dark mode.


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

The previously selected filter does not persist when the user navigates away from the conversation page, even though it is expected to remain applied until manually cleared or changed.

Solutions

Keep the state of filters in HomeStateHolder so that it's retained even if navigated to a different home destination.
Simplify the navigation between different filters and folders by just using the Crossfade when the filter changes instead of making each filter and folder a distinct destination, so it involves reverting recent changes, but now it looks more like how it supposed to be - filter is just a parameter used within the "conversation list" screen, not that each filter is a separate screen.

Testing

How to Test

Open the app, choose some filter, navigate to other home destination like settings, archive, self user profile, go back and see if the previously chosen filter is still applied.

Attachments (Optional)

Screen_recording_20241211_180951.mp4

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Dec 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 15 lines in your changes missing coverage. Please review.

Project coverage is 45.57%. Comparing base (a346709) to head (8e24c26).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...kotlin/com/wire/android/ui/home/HomeStateHolder.kt 0.00% 13 Missing ⚠️
...tionslist/filter/ConversationFilterSheetContent.kt 0.00% 0 Missing and 1 partial ⚠️
...ome/conversationslist/model/ConversationsSource.kt 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3737      +/-   ##
===========================================
- Coverage    45.58%   45.57%   -0.02%     
===========================================
  Files          476      476              
  Lines        16113    16129      +16     
  Branches      2736     2737       +1     
===========================================
+ Hits          7345     7350       +5     
- Misses        8001     8012      +11     
  Partials       767      767              
Files with missing lines Coverage Δ
...m/wire/android/ui/calling/CallActivityViewModel.kt 95.65% <100.00%> (ø)
...tionslist/filter/ConversationFilterSheetContent.kt 0.00% <0.00%> (ø)
...ome/conversationslist/model/ConversationsSource.kt 84.61% <83.33%> (-1.10%) ⬇️
...kotlin/com/wire/android/ui/home/HomeStateHolder.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a346709...8e24c26. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3737.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3737.apk is available for download

@saleniuk saleniuk requested review from Garzas, a team, m-zagorski, vitorhugods, ohassine and mathias-niboulies and removed request for a team December 13, 2024 10:30
@saleniuk saleniuk enabled auto-merge December 13, 2024 14:40
Copy link
Contributor

Built wire-android-staging-compat-pr-3737.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3737.apk is available for download

@saleniuk saleniuk added this pull request to the merge queue Dec 16, 2024
Merged via the queue into develop with commit d37cf33 Dec 16, 2024
12 of 13 checks passed
@saleniuk saleniuk deleted the fix/retain-filters-and-simplify-navigation branch December 16, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants