-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: retain filters and simplify navigation [WPB-14518] #3737
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3737 +/- ##
===========================================
- Coverage 45.58% 45.57% -0.02%
===========================================
Files 476 476
Lines 16113 16129 +16
Branches 2736 2737 +1
===========================================
+ Hits 7345 7350 +5
- Misses 8001 8012 +11
Partials 767 767
Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3737.apk is available for download |
Built wire-android-dev-debug-pr-3737.apk is available for download |
…etain-filters-and-simplify-navigation
Quality Gate passedIssues Measures |
Built wire-android-staging-compat-pr-3737.apk is available for download |
Built wire-android-dev-debug-pr-3737.apk is available for download |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
The previously selected filter does not persist when the user navigates away from the conversation page, even though it is expected to remain applied until manually cleared or changed.
Solutions
Keep the state of filters in
HomeStateHolder
so that it's retained even if navigated to a different home destination.Simplify the navigation between different filters and folders by just using the
Crossfade
when the filter changes instead of making each filter and folder a distinct destination, so it involves reverting recent changes, but now it looks more like how it supposed to be - filter is just a parameter used within the "conversation list" screen, not that each filter is a separate screen.Testing
How to Test
Open the app, choose some filter, navigate to other home destination like settings, archive, self user profile, go back and see if the previously chosen filter is still applied.
Attachments (Optional)
Screen_recording_20241211_180951.mp4
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.