Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: harden countly sdk integration (WPB-15007) #3735

Merged
merged 5 commits into from
Dec 12, 2024
Merged
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ package com.wire.android.feature.analytics
import android.app.Activity
import android.app.Application
import android.content.Context
import android.util.Log
import com.wire.android.feature.analytics.model.AnalyticsEvent
import com.wire.android.feature.analytics.model.AnalyticsEventConstants
import com.wire.android.feature.analytics.model.AnalyticsSettings
Expand All @@ -34,8 +35,8 @@ class AnonymousAnalyticsRecorderImpl : AnonymousAnalyticsRecorder {
override fun configure(
context: Context,
analyticsSettings: AnalyticsSettings
) {
if (isConfigured) return
) = wrapCountlyRequest {
if (isConfigured) return@wrapCountlyRequest

val countlyConfig = CountlyConfig(
context,
Expand All @@ -54,46 +55,48 @@ class AnonymousAnalyticsRecorderImpl : AnonymousAnalyticsRecorder {
}
}

Countly.sharedInstance().init(countlyConfig)
Countly.sharedInstance().consent().giveConsent(arrayOf("apm"))
Countly.sharedInstance()?.init(countlyConfig)
Countly.sharedInstance()?.consent()?.giveConsent(arrayOf("apm"))

val packageInfo = context.packageManager.getPackageInfo(context.packageName, 0)
val globalSegmentations = mapOf<String, Any>(
AnalyticsEventConstants.APP_NAME to AnalyticsEventConstants.APP_NAME_ANDROID,
AnalyticsEventConstants.APP_VERSION to packageInfo.versionName
)
Countly.sharedInstance().views().setGlobalViewSegmentation(globalSegmentations)
Countly.sharedInstance()?.views()?.setGlobalViewSegmentation(globalSegmentations)
isConfigured = true
}

override fun onStart(activity: Activity) {
Countly.sharedInstance().onStart(activity)
override fun onStart(activity: Activity) = wrapCountlyRequest {
Countly.sharedInstance()?.onStart(activity)
}

override fun onStop() {
Countly.sharedInstance().onStop()
override fun onStop() = wrapCountlyRequest {
Countly.sharedInstance()?.onStop()
}

/**
* We need to change our segmentation map to [MutableMap] because
* Countly is doing additional operations on it.
* See [UtilsInternalLimits.removeUnsupportedDataTypes]
*/
override fun sendEvent(event: AnalyticsEvent) {
Countly.sharedInstance().events().recordEvent(event.key, event.toSegmentation().toMutableMap())
override fun sendEvent(event: AnalyticsEvent) = wrapCountlyRequest {
Countly.sharedInstance()?.events()?.recordEvent(event.key, event.toSegmentation().toMutableMap())
}

override fun halt() {
override fun halt() = wrapCountlyRequest {
isConfigured = false
Countly.sharedInstance().consent().removeConsentAll()
Countly.sharedInstance().halt()
}

override suspend fun setTrackingIdentifierWithMerge(
identifier: String,
isTeamMember: Boolean,
migrationComplete: suspend () -> Unit
) {
Countly.sharedInstance().deviceId().changeWithMerge(identifier).also {
wrapCountlyRequest {
Countly.sharedInstance()?.deviceId()?.changeWithMerge(identifier)
}.also {
migrationComplete()
}

Expand All @@ -106,7 +109,9 @@ class AnonymousAnalyticsRecorderImpl : AnonymousAnalyticsRecorder {
isTeamMember: Boolean,
propagateIdentifier: suspend () -> Unit
) {
Countly.sharedInstance().deviceId().changeWithoutMerge(identifier)
wrapCountlyRequest {
Countly.sharedInstance()?.deviceId()?.changeWithoutMerge(identifier)
}

setUserProfileProperties(isTeamMember = isTeamMember)

Expand All @@ -115,27 +120,42 @@ class AnonymousAnalyticsRecorderImpl : AnonymousAnalyticsRecorder {
}
}

private fun setUserProfileProperties(isTeamMember: Boolean) {
Countly.sharedInstance().userProfile().setProperty(
private fun setUserProfileProperties(isTeamMember: Boolean) = wrapCountlyRequest {
Countly.sharedInstance()?.userProfile()?.setProperty(
AnalyticsEventConstants.TEAM_IS_TEAM,
isTeamMember
)
Countly.sharedInstance().userProfile().save()
Countly.sharedInstance()?.userProfile()?.save()
}

override fun isAnalyticsInitialized(): Boolean = Countly.sharedInstance().isInitialized

override fun applicationOnCreate() {
if (isConfigured) return
override fun applicationOnCreate() = wrapCountlyRequest {
if (isConfigured) return@wrapCountlyRequest

Countly.applicationOnCreate()
}

override fun recordView(screen: String) {
Countly.sharedInstance().views().startAutoStoppedView(screen)
override fun recordView(screen: String) = wrapCountlyRequest {
Countly.sharedInstance()?.views()?.startAutoStoppedView(screen)
}

override fun stopView(screen: String) = wrapCountlyRequest {
Countly.sharedInstance()?.views()?.stopViewWithName(screen)
}

@Suppress("TooGenericExceptionCaught")
private fun wrapCountlyRequest(block: () -> Unit) {
try {
block()
} catch (e: Exception) {
// Countly SDK throws exceptions on some cases, just log it
// We don't want to crash the app because of that.
Log.wtf(TAG, "Countly SDK request failed", e)
}
}

override fun stopView(screen: String) {
Countly.sharedInstance().views().stopViewWithName(screen)
companion object {
private const val TAG = "AnonymousAnalyticsRecorderImpl"
}
}
Loading