-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: revert highlight mentions while typing (WPB-1895) #3727
Open
ohassine
wants to merge
5
commits into
develop
Choose a base branch
from
revert-mention-highlight
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+129
−985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes: unplanned
Any work item that isn’t part of the product or technical roadmap.
label
Dec 11, 2024
ohassine
changed the title
chore: revert highlight mentions while typing
chore: revert highlight mentions while typing (WPB-1895)
Dec 11, 2024
echoes-hq
bot
added
the
echoes: product-roadmap
Work aligned with the customer-announced roadmap, targeting a specific release date.
label
Dec 11, 2024
@ohassine we need this also on release/candidate please 🙏 |
Ups 🫰🟨This PR is too big. Please try to break it up into smaller PRs. |
ohassine
requested review from
a team,
m-zagorski,
alexandreferris,
MohamadJaara,
vitorhugods and
mathias-niboulies
and removed request for
a team
December 11, 2024 14:28
Quality Gate passedIssues Measures |
8 tasks
MohamadJaara
approved these changes
Dec 17, 2024
vitorhugods
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
echoes: product-roadmap
Work aligned with the customer-announced roadmap, targeting a specific release date.
echoes: unplanned
Any work item that isn’t part of the product or technical roadmap.
size/XL
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
After implementing the mention highlight feature using a different BasicTextField, we realized that this approach does not support rich content due to API limitation.
As a result, we have decided to prioritize GIF support instead and will be removing the mention feature.
Needs releases with:
Testing
Test Coverage (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.