Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: conference simulcast support (WPB-11480) #3717

Merged
merged 5 commits into from
Dec 7, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Dec 6, 2024

StoryWPB-11480 [Android] Simulcast Support & Automatic Quality Adjustments

This reverts commit 7cd4bd6.


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

For safety reasons and looking for a stable version 4.10
Simulcast, we are going to be bumped out of this version.

Causes (Optional)

Rollback the commit

Needs release with


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. label Dec 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.69%. Comparing base (b27fe6a) to head (edbf4f4).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...android/ui/calling/ongoing/OngoingCallViewModel.kt 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3717      +/-   ##
===========================================
- Coverage    45.73%   45.69%   -0.04%     
===========================================
  Files          473      473              
  Lines        16057    16051       -6     
  Branches      2713     2713              
===========================================
- Hits          7344     7335       -9     
- Misses        7952     7955       +3     
  Partials       761      761              
Files with missing lines Coverage Δ
...id/ui/calling/ongoing/fullscreen/FullScreenTile.kt 0.00% <ø> (ø)
.../calling/ongoing/fullscreen/SelectedParticipant.kt 0.00% <ø> (-100.00%) ⬇️
...android/ui/calling/ongoing/OngoingCallViewModel.kt 73.13% <50.00%> (-3.19%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b27fe6a...edbf4f4. Read the comment docs.

@vitorhugods vitorhugods changed the title feat: revert - conference simulcast support (WPB-11480) revert: conference simulcast support (WPB-11480) Dec 6, 2024
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Built wire-android-staging-compat-pr-3717.apk is available for download

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Built wire-android-dev-debug-pr-3717.apk is available for download

Copy link

sonarqubecloud bot commented Dec 6, 2024

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Built wire-android-staging-compat-pr-3717.apk is available for download

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Built wire-android-dev-debug-pr-3717.apk is available for download

@yamilmedina yamilmedina added this pull request to the merge queue Dec 7, 2024
Merged via the queue into develop with commit 7c5299e Dec 7, 2024
13 of 14 checks passed
@yamilmedina yamilmedina deleted the chore/downgrade-libs-4.10 branch December 7, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants