Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter folders [WPB-14442] #3714

Merged
merged 7 commits into from
Dec 10, 2024
Merged

feat: filter folders [WPB-14442] #3714

merged 7 commits into from
Dec 10, 2024

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Dec 6, 2024

TaskWPB-14442 [Android] - Conversation Folders - filter conversation list by folder


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • implemented folders filters
  • refactored HomeDestination to dynamically change Conversation screen title
  • added SelectableMenuBottomSheetItem to conversation filters items
conversation_folders.mov

@Garzas Garzas self-assigned this Dec 6, 2024
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Dec 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 29.68750% with 45 lines in your changes missing coverage. Please review.

Project coverage is 45.63%. Comparing base (8d9b34a) to head (edb1ea7).

Files with missing lines Patch % Lines
...home/conversations/folder/ConversationFoldersVM.kt 0.00% 15 Missing ⚠️
...sationslist/filter/ConversationFilterSheetState.kt 0.00% 11 Missing ⚠️
...ome/conversationslist/ConversationListViewModel.kt 25.00% 4 Missing and 2 partials ⚠️
...tionslist/filter/ConversationFilterSheetContent.kt 0.00% 5 Missing and 1 partial ⚠️
...tions/usecase/GetConversationsFromSearchUseCase.kt 73.33% 2 Missing and 2 partials ⚠️
...kotlin/com/wire/android/ui/home/HomeStateHolder.kt 0.00% 2 Missing ⚠️
...ome/conversationslist/model/ConversationsSource.kt 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3714      +/-   ##
===========================================
- Coverage    45.70%   45.63%   -0.07%     
===========================================
  Files          473      475       +2     
  Lines        16052    16103      +51     
  Branches      2713     2736      +23     
===========================================
+ Hits          7336     7349      +13     
- Misses        7955     7990      +35     
- Partials       761      764       +3     
Files with missing lines Coverage Δ
...ome/conversationslist/model/ConversationsSource.kt 85.71% <85.71%> (-14.29%) ⬇️
...kotlin/com/wire/android/ui/home/HomeStateHolder.kt 0.00% <0.00%> (ø)
...tions/usecase/GetConversationsFromSearchUseCase.kt 80.76% <73.33%> (-4.02%) ⬇️
...ome/conversationslist/ConversationListViewModel.kt 32.93% <25.00%> (+0.57%) ⬆️
...tionslist/filter/ConversationFilterSheetContent.kt 0.00% <0.00%> (ø)
...sationslist/filter/ConversationFilterSheetState.kt 0.00% <0.00%> (ø)
...home/conversations/folder/ConversationFoldersVM.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d9b34a...edb1ea7. Read the comment docs.

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Built wire-android-staging-compat-pr-3714.apk is available for download

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Built wire-android-dev-debug-pr-3714.apk is available for download

@Garzas Garzas requested a review from saleniuk December 10, 2024 08:43
Copy link
Contributor

Built wire-android-staging-compat-pr-3714.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3714.apk is available for download

@Garzas Garzas added this pull request to the merge queue Dec 10, 2024
Copy link
Contributor

Built wire-android-staging-compat-pr-3714.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3714.apk is available for download

Merged via the queue into develop with commit e6d8091 Dec 10, 2024
13 of 14 checks passed
@Garzas Garzas deleted the feat/filter-folders branch December 10, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants