Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upload mapping file to s3 (WPB-8774) #3713

Open
wants to merge 27 commits into
base: develop
Choose a base branch
from

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Dec 5, 2024

TaskWPB-8774 [Android] implement easy to access archive of mapping files for debugging


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

Upload mapping file with the APK to S3 for non Debug builds

Screenshot 2024-12-13 at 09 48 43

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Dec 5, 2024

Built wire-android-staging-compat-pr-3713.apk is available for download

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.63%. Comparing base (375b8ca) to head (45cb2f7).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3713   +/-   ##
========================================
  Coverage    45.63%   45.63%           
========================================
  Files          477      477           
  Lines        16134    16134           
  Branches      2736     2736           
========================================
  Hits          7363     7363           
  Misses        8004     8004           
  Partials       767      767           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 375b8ca...45cb2f7. Read the comment docs.

Copy link
Contributor

github-actions bot commented Dec 5, 2024

Built wire-android-staging-compat-pr-3713.apk is available for download

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Built wire-android-staging-compat-pr-3713.apk is available for download

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Built wire-android-staging-compat-pr-3713.apk is available for download

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Built wire-android-staging-compat-pr-3713.apk is available for download

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Built wire-android-dev-debug-pr-3713.apk is available for download

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Built wire-android-staging-compat-pr-3713.apk is available for download

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Built wire-android-dev-debug-pr-3713.apk is available for download

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Built wire-android-staging-compat-pr-3713.apk is available for download

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Built wire-android-dev-debug-pr-3713.apk is available for download

Copy link
Contributor

Built wire-android-staging-compat-pr-3713.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3713.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3713.apk is available for download

Copy link
Contributor

Built wire-android-staging-compat-pr-3713.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3713.apk is available for download

@ohassine ohassine changed the title CI: upload mapping file to s3 CI: upload mapping file to s3 (WPB-8774) Dec 12, 2024
Copy link
Contributor

Built wire-android-staging-compat-pr-3713.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3713.apk is available for download

@ohassine ohassine removed WIP Work In Progress DO NOT MERGE labels Dec 13, 2024
Copy link
Contributor

Built wire-android-staging-compat-pr-3713.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3713.apk is available for download

@ohassine ohassine changed the title CI: upload mapping file to s3 (WPB-8774) chore: upload mapping file to s3 (WPB-8774) Dec 13, 2024
@ohassine ohassine requested review from a team, typfel, yamilmedina, MohamadJaara, Garzas and damian-kaczmarek and removed request for a team December 13, 2024 08:40
Copy link
Contributor

Built wire-android-staging-compat-pr-3713.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3713.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants