fix: Read receipts not generated when responding from notification (WPB-8756) #3420

ohassine · 2024-09-05T14:51:50Z

WPB-8756 [Android] Read receipts not generated when responding from notification popup

PR Submission Checklist for internal contributors

The PR Title
- conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- contains a reference JIRA issue number like SQPIT-764
- answers the question: If merged, this PR will: ... ³
The PR Description
- is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When we reply from head up notification, we don't mark older messages as read

Solutions

Call updateConversationReadDateUseCase when replying from notifications

Needs releases with:

GitHub link to other pull request

Testing

Test Coverage (Optional)

I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

PR Post Submission Checklist for internal contributors (Optional)

Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References

https://sparkbox.com/foundry/semantic_commit_messages
https://github.com/wireapp/.github#usage
E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

codecov-commenter · 2024-09-05T15:17:23Z

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 44.86%. Comparing base (9672f87) to head (7328056).
Report is 205 commits behind head on develop.

Files with missing lines	Patch %	Lines
...on/broadcastreceivers/NotificationReplyReceiver.kt	0.00%	9 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3420      +/-   ##
===========================================
- Coverage    44.88%   44.86%   -0.02%     
===========================================
  Files          466      466              
  Lines        15683    15688       +5     
  Branches      2642     2642              
===========================================
  Hits          7039     7039              
- Misses        7885     7890       +5     
  Partials       759      759

Files with missing lines	Coverage Δ
...on/broadcastreceivers/NotificationReplyReceiver.kt	`3.70% <0.00%> (-0.85%)`	⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9672f87...7328056. Read the comment docs.

github-actions · 2024-09-05T15:35:55Z

Built wire-android-staging-compat-pr-3420.apk is available for download

github-actions · 2024-09-05T15:36:07Z

Built wire-android-dev-debug-pr-3420.apk is available for download

...rc/main/kotlin/com/wire/android/notification/broadcastreceivers/NotificationReplyReceiver.kt

MohamadJaara

the goeal is to "mark only the last x number of messages that are displayed currently in the notification as read but leave the conversation as not read?" and updateConversationReadDateUseCase will also mark the conversation as read for self user

ohassine · 2024-09-09T13:15:31Z

the goeal is to "mark only the last x number of messages that are displayed currently in the notification as read but leave the conversation as not read?" and updateConversationReadDateUseCase will also mark the conversation as read for self user

But why ? if it's marked as read for other users why we keep it unread for self user ? it will be somehow confusing

…ng-from-notification

github-actions · 2024-09-09T13:58:53Z

Built wire-android-staging-compat-pr-3420.apk is available for download

github-actions · 2024-09-09T13:59:02Z

Built wire-android-dev-debug-pr-3420.apk is available for download

…ng-from-notification

github-actions · 2024-09-16T08:16:52Z

Built wire-android-staging-compat-pr-3420.apk is available for download

github-actions · 2024-09-16T08:16:59Z

Built wire-android-dev-debug-pr-3420.apk is available for download

…generated-when-responding-from-notification # Conflicts: # kalium

…ng-from-notification

sonarqubecloud · 2024-09-16T16:19:50Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions · 2024-09-16T17:05:20Z

Built wire-android-staging-compat-pr-3420.apk is available for download

github-actions · 2024-09-16T17:05:33Z

Built wire-android-dev-debug-pr-3420.apk is available for download

fix: Read receipts not generated when responding from notification

273b4ce

pull-request-size bot added the size/XS label Sep 5, 2024

echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Sep 5, 2024

ohassine requested review from a team, MohamadJaara, vitorhugods, mchenani, Garzas and saleniuk and removed request for a team September 5, 2024 14:51

github-actions bot assigned ohassine Sep 5, 2024

ohassine mentioned this pull request Sep 5, 2024

fix: Read receipts not generated when responding from notification (WPB-8756) wireapp/kalium#2994

Merged

8 tasks

MohamadJaara requested changes Sep 6, 2024

View reviewed changes

...rc/main/kotlin/com/wire/android/notification/broadcastreceivers/NotificationReplyReceiver.kt Show resolved Hide resolved

MohamadJaara approved these changes Sep 6, 2024

View reviewed changes

MohamadJaara requested changes Sep 6, 2024

View reviewed changes

Merge branch 'develop' into Read-receipts-not-generated-when-respondi…

8ebf442

…ng-from-notification

ohassine requested a review from MohamadJaara September 9, 2024 13:15

borichellow approved these changes Sep 11, 2024

View reviewed changes

yamilmedina approved these changes Sep 11, 2024

View reviewed changes

MohamadJaara approved these changes Sep 13, 2024

View reviewed changes

ohassine added 2 commits September 16, 2024 09:36

Merge branch 'develop' into Read-receipts-not-generated-when-respondi…

b08658f

…ng-from-notification

chore: kalium reference

08090e6

MohamadJaara added this pull request to the merge queue Sep 16, 2024

github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Sep 16, 2024

ohassine added 2 commits September 16, 2024 12:41

chore: kalium reference

434a56f

Merge remote-tracking branch 'origin/develop' into Read-receipts-not-…

dd47404

…generated-when-responding-from-notification # Conflicts: # kalium

ohassine enabled auto-merge September 16, 2024 10:42

Merge branch 'develop' into Read-receipts-not-generated-when-respondi…

7328056

…ng-from-notification

ohassine added this pull request to the merge queue Sep 16, 2024

Merged via the queue into develop with commit 996490b Sep 16, 2024
11 of 12 checks passed

ohassine deleted the Read-receipts-not-generated-when-responding-from-notification branch September 16, 2024 17:07

echoes-hq bot added echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. and removed echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. labels Jan 13, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Read receipts not generated when responding from notification (WPB-8756) #3420

fix: Read receipts not generated when responding from notification (WPB-8756) #3420

ohassine commented Sep 5, 2024 •

edited by github-actions bot

Loading

codecov-commenter commented Sep 5, 2024 •

edited

Loading

github-actions bot commented Sep 5, 2024

github-actions bot commented Sep 5, 2024

MohamadJaara left a comment

ohassine commented Sep 9, 2024 •

edited

Loading

github-actions bot commented Sep 9, 2024

github-actions bot commented Sep 9, 2024

github-actions bot commented Sep 16, 2024

github-actions bot commented Sep 16, 2024

sonarqubecloud bot commented Sep 16, 2024

github-actions bot commented Sep 16, 2024

github-actions bot commented Sep 16, 2024

fix: Read receipts not generated when responding from notification (WPB-8756) #3420

fix: Read receipts not generated when responding from notification (WPB-8756) #3420

Conversation

ohassine commented Sep 5, 2024 • edited by github-actions bot Loading

PR Submission Checklist for internal contributors

What's new in this PR?

Issues

Solutions

Testing

Test Coverage (Optional)

How to Test

Notes (Optional)

Attachments (Optional)

PR Post Submission Checklist for internal contributors (Optional)

PR Post Merge Checklist for internal contributors

References

codecov-commenter commented Sep 5, 2024 • edited Loading

Codecov Report

github-actions bot commented Sep 5, 2024

github-actions bot commented Sep 5, 2024

MohamadJaara left a comment

Choose a reason for hiding this comment

ohassine commented Sep 9, 2024 • edited Loading

github-actions bot commented Sep 9, 2024

github-actions bot commented Sep 9, 2024

github-actions bot commented Sep 16, 2024

github-actions bot commented Sep 16, 2024

sonarqubecloud bot commented Sep 16, 2024

Quality Gate passed

github-actions bot commented Sep 16, 2024

github-actions bot commented Sep 16, 2024

ohassine commented Sep 5, 2024 •

edited by github-actions bot

Loading

codecov-commenter commented Sep 5, 2024 •

edited

Loading

ohassine commented Sep 9, 2024 •

edited

Loading