Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change default lineLimits for text fields to be single-line #3095

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Jun 12, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

For new text fields v2 by default TextFieldLineLimits.Default is Multiline, in most cases it shouldn't be a problem because we have keyboard action DONE by default so there shouldn't be a "new line" button at all, but in case someone uses custom keyboard or external one, it could be possible to enter a new line in text field which shouldn't allow to do that.

Solutions

Change the default value of lineLimits for our text fields to be SingleLine so that we need to intentionally set it to Multiline when needed.

Testing

How to Test

Attach external keyboard or use Android Studio mirroring to use keyboard from your computer, open for instance login screen and press "enter" to try to insert new line.

Attachments (Optional)

In both videos user presses "enter" key on external keyboard, on second one it actually moves the focus to the next input instead of creating a new line so it works properly like the action button.

Before After
login_newline.mp4
login_newline_fix.mp4

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@saleniuk saleniuk requested review from a team, typfel, yamilmedina, MohamadJaara, mchenani and Garzas and removed request for a team June 12, 2024 10:55
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

Built wire-android-staging-release-pr-3095.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3095.apk is available for download

@AndroidBob
Copy link
Collaborator

Build 5274 succeeded.

The build produced the following APK's:

@ohassine ohassine added this pull request to the merge queue Jun 12, 2024
Merged via the queue into develop with commit a7f127f Jun 12, 2024
14 checks passed
@ohassine ohassine deleted the fix/change-default-textfield-to-singleline branch June 12, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants