fix: change default lineLimits for text fields to be single-line #3095
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
For new text fields v2 by default
TextFieldLineLimits.Default
isMultiline
, in most cases it shouldn't be a problem because we have keyboard actionDONE
by default so there shouldn't be a "new line" button at all, but in case someone uses custom keyboard or external one, it could be possible to enter a new line in text field which shouldn't allow to do that.Solutions
Change the default value of
lineLimits
for our text fields to beSingleLine
so that we need to intentionally set it toMultiline
when needed.Testing
How to Test
Attach external keyboard or use Android Studio mirroring to use keyboard from your computer, open for instance login screen and press "enter" to try to insert new line.
Attachments (Optional)
In both videos user presses "enter" key on external keyboard, on second one it actually moves the focus to the next input instead of creating a new line so it works properly like the action button.
login_newline.mp4
login_newline_fix.mp4
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.