Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: After sending a reaction, keyboard opens automatically (WPB-9358) #3085

Merged

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Jun 6, 2024

BugWPB-9358 [Android] After sending a reaction, keyboard opens automatically


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

After sending a reaction, keyboard opens automatically

Causes (Optional)

Focus on text field is still active

Solutions

Clear focus when inputFocused is false

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@AndroidBob
Copy link
Collaborator

Build 5221 failed.

@ohassine ohassine requested review from a team, typfel, MohamadJaara, vitorhugods, mchenani and Garzas and removed request for a team June 7, 2024 07:36
@AndroidBob
Copy link
Collaborator

Build 5236 failed.

@ohassine ohassine enabled auto-merge June 7, 2024 09:11
Copy link

sonarqubecloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ohassine ohassine added this pull request to the merge queue Jun 7, 2024
Merged via the queue into develop with commit 61eacdc Jun 7, 2024
10 of 11 checks passed
@ohassine ohassine deleted the After-sending-a-reaction,-keyboard-opens-automatically branch June 7, 2024 09:55
@AndroidBob
Copy link
Collaborator

Build 5242 failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants