fix: run UI logic on the main thread [WPB-9458]

[MohamadJaara]

WPB-9458 [Android] crash in wire activity

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

wire activity crashes when clearing view model

Solutions

we suspect that it have to do with changes in

wire-android/app/src/main/kotlin/com/wire/android/ui/WireActivity.kt

Lines 466 to 485 in 1d959e1

	override fun onResume() {
	super.onResume()
	lifecycleScope.launch(Dispatchers.Default) {
	lockCodeTimeManager.get().observeAppLock()
	// Listen to one flow in a lifecycle-aware manner using flowWithLifecycle
	.flowWithLifecycle(lifecycle, Lifecycle.State.STARTED)
	.first().let {
	if (it) {
	withContext(Dispatchers.Main) {
	startActivity(
	Intent(this@WireActivity, AppLockActivity::class.java)
	)
	}
	}
	}
	}
	proximitySensorManager.registerListener()
	}

so reverting the changes should do the trick

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

• GitHub link to other pull request

Testing

Test Coverage (Optional)

• I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[ohassine]

Why reverting all the commit and not just removing the default dispatcher from here ?

 lifecycleScope.launch(Dispatchers.Default) { 
         lockCodeTimeManager.get().observeAppLock() 
             // Listen to one flow in a lifecycle-aware manner using flowWithLifecycle 
             .flowWithLifecycle(lifecycle, Lifecycle.State.STARTED) 
             .first().let { 

[github-actions]

Test Results

928 tests   928 ✅  12m 10s ⏱️
123 suites    0 💤
123 files      0 ❌

Results for commit a496deb.

[github-actions]

APKs built during tests are available here. Scroll down to Artifacts!

[MohamadJaara]

Why reverting all the commit and not just removing the default dispatcher from here ?

 lifecycleScope.launch(Dispatchers.Default) { 
         lockCodeTimeManager.get().observeAppLock() 
             // Listen to one flow in a lifecycle-aware manner using flowWithLifecycle 
             .flowWithLifecycle(lifecycle, Lifecycle.State.STARTED) 
             .first().let { 

the changes does more or less nothing for example observePersistentConnectionStatus starts with viewModelScope.launch which which bring the function back to the main thread.

[ohassine]

Why reverting all the commit and not just removing the default dispatcher from here ?

 lifecycleScope.launch(Dispatchers.Default) { 
         lockCodeTimeManager.get().observeAppLock() 
             // Listen to one flow in a lifecycle-aware manner using flowWithLifecycle 
             .flowWithLifecycle(lifecycle, Lifecycle.State.STARTED) 
             .first().let { 

the changes does more or less nothing for example observePersistentConnectionStatus starts with viewModelScope.launch which which bring the function back to the main thread.

No the child coroutine works on same dispatcher as the parent if we don't specify it on launch

[AndroidBob]

Build 5084 succeeded.

The build produced the following APK's:

• com.wire.android-v4.7.1(9802271)(9802271)-staging-compat.apk