Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: scroll bottom - jump to last message (WPB-4987) (WPB-3973) #2343

Merged
merged 10 commits into from
Oct 18, 2023

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Oct 18, 2023

StoryWPB-4987 [Android] Add a button to jump to the latest message


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We don't have a way in the app to quickly navigate to the bottom of the messages list, aka. jump to last message.

Solutions

Implement it by using Scaffold FAB embedded into messages list component, taking at the same time advantage that MessagesList component, passed down is a composable, so I was able to have it for free for Disabled message composer as well.

Using the outer scaffold was not an option after many tries, because it also considers the attachment options menu, making it almost impossible to customize the position dynamically.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Scroll so the last message is hidden, then the button should appear.

Attachments (Optional)

###Conversations with several messages and without scrollable content

Screen.Recording.2023-10-18.at.15.13.12.mov

###Read only Conversations

Screen.Recording.2023-10-18.at.15.36.19.mov

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina changed the title feat: scroll bottom - jump to last message (WPB-4987) feat: scroll bottom - jump to last message (WPB-4987) (WPB-3973) Oct 18, 2023
@github-actions
Copy link
Contributor

Test Results

649 tests  ±0   649 ✔️ ±0   9m 13s ⏱️ + 2m 14s
  94 suites ±0       0 💤 ±0 
  94 files   ±0       0 ±0 

Results for commit 9f1d757. ± Comparison against base commit 22d380a.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Copy link
Contributor

@Garzas Garzas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice 🧑‍🍳
Just one question: do we have 2 scaffolds in the composable tree? I think we can achieve similar functionality with adding box with some ime padding for this button? 🤔

@AndroidBob
Copy link
Collaborator

Build 1413 succeeded.

The build produced the following APK's:

@Garzas Garzas self-requested a review October 18, 2023 14:58
Copy link
Member

@vitorhugods vitorhugods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⬇️

@yamilmedina yamilmedina added this pull request to the merge queue Oct 18, 2023
Merged via the queue into develop with commit e302061 Oct 18, 2023
19 checks passed
@yamilmedina yamilmedina deleted the feat/jump-to-last-msg-gitfix branch October 18, 2023 16:11
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants