Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update compose destinations and navigation libs #2339

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

saleniuk
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

After upgrading AGP and sdk to 34, we can now update the navigation libs: compose destinations and compose navigation, and use recent accompanist lib (previously it was causing troubles and had to be adjusted to work well with the compose destinations lib version used).


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

Test Results

649 tests  ±0   649 ✔️ ±0   6m 6s ⏱️ - 2m 40s
  94 suites ±0       0 💤 ±0 
  94 files   ±0       0 ±0 

Results for commit b96c09f. ± Comparison against base commit 15e4e80.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@saleniuk saleniuk requested a review from Garzas October 17, 2023 15:02
@AndroidBob
Copy link
Collaborator

Build 1370 succeeded.

The build produced the following APK's:

@saleniuk saleniuk added this pull request to the merge queue Oct 18, 2023
Merged via the queue into develop with commit 0eefaaf Oct 18, 2023
10 checks passed
@saleniuk saleniuk deleted the chore/update_navigation_libs branch October 18, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants