Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Show e2ei certificate in device details screen - PART 1 (WPB-3214) #2316

Merged
merged 21 commits into from
Oct 25, 2023
Merged

feat: Show e2ei certificate in device details screen - PART 1 (WPB-3214) #2316

merged 21 commits into from
Oct 25, 2023

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Oct 11, 2023 •
edited by github-actions bot
Loading

StoryWPB-3214 [Android] 5.3.24 Show E2EI certificate info

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

In this PR, I am creating the required UI for displaying E2EI certificate with it's different states.

Next PR will be for calling correspondent use cases.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Go device details

Attachments (Optional)

Wire 2023-10-11 at 4_03 PM

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023 •
edited
Loading

Test Results

652 tests  ±0   652 ✔️ ±0   8m 55s ⏱️ + 1m 8s
  96 suites ±0       0 💤 ±0 
  96 files   ±0       0 ❌ ±0 

Results for commit a758be1. ± Comparison against base commit d939a9b.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 1243 failed.

@AndroidBob
Copy link
Collaborator

Build 1244 failed.

@ohassine ohassine changed the title feat: Show e2ei certificate in device details screen - PART 1 feat: Show e2ei certificate in device details screen - PART 1 (WPB-3214) Oct 11, 2023
@AndroidBob
Copy link
Collaborator

Build 1247 failed.

@ohassine ohassine added the WIP Work In Progress label Oct 12, 2023
@AndroidBob
Copy link
Collaborator

Build 1291 failed.

@AndroidBob
Copy link
Collaborator

Build 1294 failed.

@AndroidBob
Copy link
Collaborator

Build 1295 failed.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1298 succeeded.

The build produced the following APK's:

@github-actions
Copy link
Contributor

@ohassine looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
4d801fc83ff23b824c987d4347e2d8083bd850c6 dbfaf56178bce195a40bfab0a5d9c062aeee7f7a

Is this intentional?

@AndroidBob
Copy link
Collaborator

Build 1324 failed.

@ohassine ohassine mentioned this pull request Oct 16, 2023
Merged
7 tasks
@ohassine ohassine removed the WIP Work In Progress label Oct 16, 2023
@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1348 succeeded.

The build produced the following APK's:

@ohassine ohassine requested review from a team, typfel, borichellow, vitorhugods, mchenani and saleniuk and removed request for a team October 23, 2023 15:16
@ohassine
Merge remote-tracking branch 'origin/develop' into show_e2ei_certificate
3c04369 
# Conflicts:
#	app/src/main/kotlin/com/wire/android/ui/theme/WireColorScheme.kt
#	kalium
@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

mchenani
mchenani approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@mchenani mchenani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘

@AndroidBob
Copy link
Collaborator

Build 1508 succeeded.

The build produced the following APK's:

@ohassine ohassine enabled auto-merge October 25, 2023 11:51
@AndroidBob
Copy link
Collaborator

Build 1519 failed.

@ohassine
chore: fix broken build with temp params
c8ba6d4
@ohassine
Merge remote-tracking branch 'origin/develop' into show_e2ei_certificate
aedc6ac 
# Conflicts:
#	app/src/main/kotlin/com/wire/android/ui/home/conversations/details/GroupConversationDetailsViewModel.kt
#	app/src/main/kotlin/com/wire/android/ui/home/conversationslist/ConversationListViewModel.kt
#	app/src/main/kotlin/com/wire/android/ui/userprofile/other/OtherUserProfileScreenViewModel.kt
@ohassine ohassine disabled auto-merge October 25, 2023 13:17
@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@ohassine ohassine added this pull request to the merge queue Oct 25, 2023
@AndroidBob
Copy link
Collaborator

Build 1530 succeeded.

The build produced the following APK's:

Merged via the queue into develop with commit 7320d6b Oct 25, 2023
12 checks passed
@ohassine ohassine deleted the show_e2ei_certificate branch October 25, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchenani mchenani mchenani approved these changes

@alexandreferris alexandreferris alexandreferris approved these changes

@typfel typfel Awaiting requested review from typfel typfel was automatically assigned from wireapp/android

@borichellow borichellow Awaiting requested review from borichellow borichellow was automatically assigned from wireapp/android

@vitorhugods vitorhugods Awaiting requested review from vitorhugods vitorhugods was automatically assigned from wireapp/android

@saleniuk saleniuk Awaiting requested review from saleniuk saleniuk was automatically assigned from wireapp/android

Assignees

@ohassine ohassine

Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ohassine @AndroidBob @alexandreferris @mchenani