feat: Adding option on bottom sheet to archive use cases #2262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to feat/adding_archiving_use_cases # Conflicts: # app/src/main/kotlin/com/wire/android/di/CoreLogicModule.kt
|
Build 919 failed. |
|
Build 928 failed. |
…wire-android-reloaded into feat/adding_archiving_use_cases
|
Build 931 failed. |
Garzas
requested changes
Sep 25, 2023
...main/kotlin/com/wire/android/ui/home/conversations/details/GroupConversationDetailsScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/com/wire/android/ui/home/conversationslist/ConversationListViewModel.kt
Outdated
Show resolved
Hide resolved
…to feat/adding_archiving_use_cases
…to feat/adding_archiving_use_cases
Garzas
approved these changes
Sep 25, 2023
|
Build 951 failed. |
|
Build 965 failed. |
…to feat/adding_archiving_use_cases
gongracr
requested review from
a team,
yamilmedina,
alexandreferris,
borichellow and
vitorhugods
and removed request for
a team
|
Build 972 failed. |
alexandreferris
approved these changes
Sep 26, 2023
…to feat/adding_archiving_use_cases
|
Build 985 failed. |
Codecov Report
@@ Coverage Diff @@
## develop #2262 +/- ##
=============================================
+ Coverage 40.41% 40.51% +0.09%
- Complexity 1012 1015 +3
=============================================
Files 318 318
Lines 11635 11661 +26
Branches 1546 1550 +4
=============================================
+ Hits 4702 4724 +22
- Misses 6492 6493 +1
- Partials 441 444 +3
Continue to review full report in Codecov by Sentry.
|
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 990 succeeded. The build produced the following APK's: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
We need an option to be able to archive conversations visually and consume
updateConversationArchivedStatusUseCase.Solutions
Added the option on the different bottom sheets displayed when interacting with conversations options in
HomeScreen,GroupConversationDetailsScreen, andOtherUserProfileScreen. I also added the respective snackbar messages on success and failed states.Dependencies (Optional)
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Load conversations in
HomeScreen, long tap on a given one and click onMove to archiveoption. Check the conversation disappears and doesn't get displayed anymore. This behavior can also be replicated on Other users profile screen and on Group details screen.Attachments (Optional)
Grabacion.de.pantalla.2023-09-22.a.las.15.32.29.mov
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.