feat: Conversation MLS verification status updating (WPB-3872) #2224
Conversation
|
|
Test Results622 tests - 1 621 ✔️ - 1 3m 59s ⏱️ - 5m 16s Results for commit 1fb8030. ± Comparison against base commit 4e7a254. This pull request removes 1 test.♻️ This comment has been updated with latest results. |
|
Build 715 failed. |
|
Build 727 failed. |
Codecov Report
@@ Coverage Diff @@
## develop #2224 +/- ##
=============================================
- Coverage 40.51% 40.49% -0.02%
Complexity 1014 1014
=============================================
Files 318 318
Lines 11670 11668 -2
Branches 1553 1552 -1
=============================================
- Hits 4728 4725 -3
- Misses 6497 6498 +1
Partials 445 445
Continue to review full report in Codecov by Sentry.
|
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 734 succeeded. The build produced the following APK's: |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 764 succeeded. The build produced the following APK's: |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 767 succeeded. The build produced the following APK's: |
|
Just converting to draft while there is no description. |
borichellow
requested review from
saleniuk
and removed request for
saleniuk
| @@ -194,6 +180,24 @@ private fun ConversationScreenTopAppBarContent( | |||
| ) | |||
| } | |||
|
|
|||
| @Composable | |||
| private fun VerificationIcon(protocolInfo: Conversation.ProtocolInfo?) { | |||
| if (protocolInfo?.verificationStatus != Conversation.VerificationStatus.VERIFIED) return | |||
There was a problem hiding this comment.
| if (protocolInfo?.verificationStatus != Conversation.VerificationStatus.VERIFIED) return | |
| if (protocolInfo?.verificationStatus == Conversation.VerificationStatus.NOT_VERIFIED) return |
There was a problem hiding this comment.
do not agree. If the conversation status is Degraded we shouldn't display any icon just like it's not verified (design )
|
Build 913 failed. |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 937 succeeded. The build produced the following APK's: |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 999 succeeded. The build produced the following APK's: |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 1025 succeeded. The build produced the following APK's: |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 1038 succeeded. The build produced the following APK's: |
|
APKs built during tests are available here. Scroll down to Artifacts! |
borichellow
deleted the
feat/conversation_mls_verification_status_updating
branch
|
Build 1046 succeeded. The build produced the following APK's: |
What's new in this PR?
In fact just adopting AR to changes from kalium PR
including:
removing usage of
GetConversationVerificationStatusUseCaseas the observing of conversation verification state is done inObserveConversationDetailsUseCaseNeeds releases with: