Skip to content

Commit

Permalink
fix: Improve conversation join page copies (#4426)
Browse files Browse the repository at this point in the history
  • Loading branch information
atomrc authored Sep 11, 2023
1 parent de1448a commit df9ff57
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 9 deletions.
10 changes: 3 additions & 7 deletions src/i18n/en-US.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,8 @@
"conversationJoin": {
"loading": "Verifying link...",
"description": "Audio and video conferencing, text messaging, file sharing, and screen sharing, all end-to-end-encrypted.",
"wirelessHeadline": "Don't want to create a {{brandName}} account?",
"wirelessLink": "Join the conversation as a temporary guest",
"wirelessNote": "(access expires after 24 hours)",
"conversationLocation": "The conversation takes place on {{domain}}",
"wirelessHeadline": "Don't have a {{brandName}} account? You can join as temporary guest in the browser.",
"errorConversationNotFoundDescription": "The link to this group conversation has expired or is no longer valid.",
"errorConversationNotFoundHeadline": "Conversation not found",
"title": "You have been invited to join a conversation in {{brandName}}",
Expand All @@ -84,10 +83,7 @@
"cannotJoinOnMobile": "At the moment, you can't join this conversation on your mobile device. Please open this link on your desktop instead."
},
"conversationJoinSelfHosted": {
"title": "You have been invited to join a Wire conversation",
"wirelessHeadline": "The conversation is hosted on {{domain}}.",
"wirelessHaveAccount": "Don't have a Wire account on this domain?",
"wirelessLink": "Join as Temporary Guest"
"title": "You have been invited to join conversation in Wire"
},
"userProfile": {
"title": "You have been invited to view a user profile in {{brandName}}",
Expand Down
4 changes: 2 additions & 2 deletions src/script/component/DirectDownloadButton.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

import {Runtime} from '@wireapp/commons';
import {OperatingSystem} from '@wireapp/commons/src/main/util/Runtime';
import {ButtonLink, ButtonProps, COLOR} from '@wireapp/react-ui-kit';
import {ButtonLink, ButtonProps, ButtonVariant} from '@wireapp/react-ui-kit';
import {useTranslation} from 'react-i18next';
import {
BRAND_NAME,
Expand All @@ -45,7 +45,7 @@ const DirectDownloadButton = ({children, ...props}: Props) => {

return (
<ButtonLink
backgroundColor={COLOR.GREEN}
variant={ButtonVariant.SECONDARY}
href={SYSTEM_DEPENDENT_LINKS[Runtime.getOSFamily()] || DEFAULT_LINK}
data-uie-name="go-direct-download"
{...props}
Expand Down
7 changes: 7 additions & 0 deletions src/script/page/ConversationJoin.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import {
H1,
H2,
Loading,
Paragraph,
QUERY,
QueryKeys,
Small,
Expand Down Expand Up @@ -96,6 +97,12 @@ export const ConversationJoin: React.FC<ConversationJoinProps> = ({location}) =>
{hasDisplayedButtons() ? (
<>
<Text block>{t('description', {ns: translationNamespaces})}</Text>
<Paragraph muted css={{marginTop: '8px'}}>
{t('conversationLocation', {domain, ns: translationNamespaces})}
</Paragraph>
<Paragraph muted css={{marginTop: '8px'}}>
{t('wirelessHeadline', {brandName: BRAND_NAME, domain, ns: translationNamespaces})}
</Paragraph>
<FlexBox flexWrap="wrap" column={isMobile} css={{marginTop: 24}}>
<OpenWireButtons
translate={(key, substitutes) => t(key, {...substitutes, ns: translationNamespaces})}
Expand Down

0 comments on commit df9ff57

Please sign in to comment.