Code

Code complete for January#4

Code

Open

beltram wants to merge 122 commits intomasterwireapp/smallstep-certificates:masterfrom feat/zuluwireapp/smallstep-certificates:feat/zuluCopy head branch name to clipboard

+3,463-683

Commits

Commits on Jan 13, 2023

• Add Wire authz and challenges (OIDC+DPOP)

  stefanwire

  committed
  1760d0a

  Copy full SHA for 1760d0a

• adapt Github actions

  stefanwire

  committed
  c01f748

  Copy full SHA for c01f748

• add Helm charts

  stefanwire

  committed
  63ec8fc

  Copy full SHA for 63ec8fc

Commits on Jan 31, 2023

• update wire challenges' status on happy end

  stefanwire

  committed
  5603e13

  Copy full SHA for 5603e13

Commits on Feb 1, 2023

• add debugging code

  stefanwire

  committed
  66d853e

  Copy full SHA for 66d853e

• simplify OIDC verification

  stefanwire

  committed
  5f5b556

  Copy full SHA for 5f5b556

Commits on Feb 2, 2023

• log errors

  beltram

  committed
  7e7589d

  Copy full SHA for 7e7589d

• log a missing error

  beltram

  committed
  77f8101

  Copy full SHA for 77f8101

• use json struct for challenge request payload otherwise it's a hell to craft from client side

  beltram

  committed
  b8e938b

  Copy full SHA for b8e938b

• acquire DPoP signing key from provisioner

  stefanwire

  committed
  e41bc39

  Copy full SHA for e41bc39

• better observability

  beltram

  committed
  b6019ae

  Copy full SHA for b6019ae

• avoid panic when OIDC config is not provided

  stefanwire

  committed
  582e029

  Copy full SHA for 582e029

• fixup! add Helm charts

  stefanwire

  committed
  da357eb

  Copy full SHA for da357eb

• print oidc options

  beltram

  committed
  e30e6d1

  Copy full SHA for e30e6d1

• print nested error

  beltram

  committed
  7d3fa20

  Copy full SHA for 7d3fa20

Commits on Feb 3, 2023

• print dpop sign key

  beltram

  committed
  2c932cf

  Copy full SHA for 2c932cf

• fix: challenge is '.token' and not '.id'

  beltram

  committed
  19cc522

  Copy full SHA for 19cc522

• temp: use rusty-jwt-tools test branch

  beltram

  committed
  6de2831

  Copy full SHA for 6de2831

• print cli stdout

  beltram

  committed
  53f9af5

  Copy full SHA for 53f9af5

Commits on Feb 6, 2023

• debug output

  Show description for 6929acb
  stefanwire

  committed
  6929acb

  Copy full SHA for 6929acb

• fix hash algorithm passed to cli

  beltram

  committed
  befc378

  Copy full SHA for befc378

• avoid manipulating the key PEM format and take a plain PEM key as input

  beltram

  committed
  669c74c

  Copy full SHA for 669c74c

• print oidc claims

  beltram

  committed
  b3e8cd9

  Copy full SHA for b3e8cd9

• print keyauth

  beltram

  committed
  869074b

  Copy full SHA for 869074b

Commits on Feb 7, 2023

• debug KeyAuthorization

  beltram

  committed
  e3ee0d7

  Copy full SHA for e3ee0d7

• debug oidc claims validation

  beltram

  committed
  cfd240c

  Copy full SHA for cfd240c

• cleanup some panicking debugs

  beltram

  committed
  9b994cc

  Copy full SHA for 9b994cc

• debug csr org validation

  beltram

  committed
  5a2f5b6

  Copy full SHA for 5a2f5b6

• fix csr org validation in finalize

  beltram

  committed
  5d3d660

  Copy full SHA for 5d3d660

• fix csr domain validation in finalize

  beltram

  committed
  7b1f61a

  Copy full SHA for 7b1f61a

Commits on Feb 8, 2023

• (finalize) have both display name & domain in SANs

  beltram

  committed
  3f42e0d

  Copy full SHA for 3f42e0d

• fix orderNames size

  beltram

  committed
  40f56b4

  Copy full SHA for 40f56b4

• cleanup my mess

  beltram

  committed
  68a0bca

  Copy full SHA for 68a0bca

Commits on Feb 9, 2023

• fix san validation

  beltram

  committed
  0a7aa34

  Copy full SHA for 0a7aa34

• change uri prefix to impp:wireapp=

  beltram

  committed
  8fa3800

  Copy full SHA for 8fa3800

• debug space in display name

  beltram

  committed
  7799a4d

  Copy full SHA for 7799a4d

• wtf

  beltram

  committed
  82c2ae5

  Copy full SHA for 82c2ae5

• wtf part(2)

  beltram

  committed
  a7b76b0

  Copy full SHA for a7b76b0

• skip empty entries for uniqueSortedLowerNames

  stefanwire

  committed
  a261aea

  Copy full SHA for a261aea

• cleanup

  beltram

  committed
  1bdc315

  Copy full SHA for 1bdc315

Commits on Feb 10, 2023

• build: build docker image from rusty-jwt-tools main branch

  beltram

  committed
  dbcb729

  Copy full SHA for dbcb729

Commits on Feb 23, 2023

• feat: adapt to dex and pass the 'keyauth' in payload instead of in id_token. Also have a different mapping for id_token claims name

  beltram

  committed
  9446723

  Copy full SHA for 9446723

Commits on Feb 24, 2023

• error logging is back (as it should always be)

  beltram

  committed
  238d235

  Copy full SHA for 238d235

• log the sub error

  beltram

  committed
  d2a96c0

  Copy full SHA for d2a96c0

Commits on Mar 6, 2023

• feat: change from impp prefix to just im

  beltram

  committed
  93c3545

  Copy full SHA for 93c3545

• build rusty-jwt-tools from dex branch

  beltram

  committed
  d26f747

  Copy full SHA for d26f747

Commits on Mar 7, 2023

• fix: exclude displayName from SAN DNS

  beltram

  committed
  af65dc4

  Copy full SHA for af65dc4

Commits on Mar 8, 2023

• remove displayName validation, potentially harmful

  beltram

  committed
  9138ff5

  Copy full SHA for 9138ff5

• forward displayName in CSR with custom OID

  beltram

  committed
  800d832

  Copy full SHA for 800d832

Commits on Mar 22, 2023

• upgrade dependencies

  stefanwire

  committed
  472cad1

  Copy full SHA for 472cad1

Commits on Mar 28, 2023

• try using google oidc for demo purpose

  beltram

  committed
  2a354cd

  Copy full SHA for 2a354cd

Commits on Mar 29, 2023

• dbg google oidc challenge claims matching

  beltram

  committed
  9d6085f

  Copy full SHA for 9d6085f

• fix google id token matching in oidc challenge

  beltram

  committed
  9d80a1f

  Copy full SHA for 9d80a1f

• infer domain from google email address

  beltram

  committed
  24ba504

  Copy full SHA for 24ba504

• dbg again

  beltram

  committed
  336d0e0

  Copy full SHA for 336d0e0

• debounce logs

  beltram

  committed
  22e8821

  Copy full SHA for 22e8821

Commits on Mar 30, 2023

• adapt google demo for wire's special handle format "{firstname}_wire"

  beltram

  committed
  d3d2714

  Copy full SHA for d3d2714

Commits on Apr 3, 2023

• add logs again

  beltram

  committed
  bc4f20c

  Copy full SHA for bc4f20c

• fix: add URI prefix to handle

  beltram

  committed
  675c9d9

  Copy full SHA for 675c9d9

Commits on Apr 4, 2023

• fix: do not convert URIs to lowercase for comparison purpose

  beltram

  committed
  5460c46

  Copy full SHA for 5460c46

Commits on May 4, 2023

• wip

  beltram

  committed
  5ee4690

  Copy full SHA for 5ee4690

• fix: challenge target field was not mapped to db entity

  beltram

  committed
  f806c58

  Copy full SHA for f806c58

• dbg target computation

  beltram

  committed
  c162a78

  Copy full SHA for c162a78

• add oidc target

  beltram

  committed
  5930e94

  Copy full SHA for 5930e94

• simpler

  beltram

  committed
  c10f0c2

  Copy full SHA for c10f0c2

• passing expected issuer to rusty-jwt-cli

  beltram

  committed
  feaed30

  Copy full SHA for feaed30

Commits on May 5, 2023

• remove logs

  beltram

  committed
  aa710b5

  Copy full SHA for aa710b5

• remove custom rusty-jwt-tools branch for building cli

  beltram

  committed
  1ad662a

  Copy full SHA for 1ad662a

• Replace field access by accessor functions

  stefanwire

  committed
  537984b

  Copy full SHA for 537984b

• Reorganize parsing target

  stefanwire

  committed
  e8ffd84

  Copy full SHA for e8ffd84

• reintroduce custom rusty-jwt-tools branch to test a thing

  beltram

  committed
  972560b

  Copy full SHA for 972560b

• dbg issuer in dpop challenge

  beltram

  committed
  fe036bf

  Copy full SHA for fe036bf

• fix deviceId computing in dpop challenge

  beltram

  committed
  1e1ba74

  Copy full SHA for 1e1ba74

Commits on May 10, 2023

• Merge pull request #2 from wireapp/feat/target-htu

  Show description for 5a06603
  beltram

  authored
  5a06603

  Copy full SHA for 5a06603

Commits on May 26, 2023

• trying to pass access token to template

  beltram

  committed
  b8284f0

  Copy full SHA for b8284f0

• remove custom rusty-jwt-tools branch

  beltram

  committed
  04983b9

  Copy full SHA for 04983b9

• try silencing template data for dichotomies

  beltram

  committed
  cb22af5

  Copy full SHA for cb22af5

• try the dummiest example

  beltram

  committed
  9fc0c39

  Copy full SHA for 9fc0c39

• try another way

  beltram

  committed
  77a65b6

  Copy full SHA for 77a65b6

• try another way (2)

  beltram

  committed
  1dd58d0

  Copy full SHA for 1dd58d0

• try by storing everything in db

  beltram

  committed
  2e02f92

  Copy full SHA for 2e02f92

• dbg some stuffs

  beltram

  committed
  f009b66

  Copy full SHA for f009b66

• dbg account id

  beltram

  committed
  3decbfb

  Copy full SHA for 3decbfb

• have updateOrder also update the update joint table [order by account]

  beltram

  committed
  938a349

  Copy full SHA for 938a349

• at that point, log the whole universe and pray to figure something out

  beltram

  committed
  89bf043

  Copy full SHA for 89bf043

• log more things

  beltram

  committed
  7358854

  Copy full SHA for 7358854

• cheat by allowing also looking up for ready orders

  beltram

  committed
  23c5c44

  Copy full SHA for 23c5c44

• wip

  beltram

  committed
  4f5e0f4

  Copy full SHA for 4f5e0f4

• logs to understand dpop db

  beltram

  committed
  308ecff

  Copy full SHA for 308ecff

• fix dpop token json serialization to db

  beltram

  committed
  d3d4215

  Copy full SHA for d3d4215

• more logs

  beltram

  committed
  868ffd7

  Copy full SHA for 868ffd7

• i'm tired

  beltram

  committed
  dd6389f

  Copy full SHA for dd6389f

• remove logs

  beltram

  committed
  3d447d8

  Copy full SHA for 3d447d8

• support for oidc id token

  beltram

  committed
  e85f184

  Copy full SHA for e85f184

• fix: verify custom display_name extension is present

  beltram

  committed
  a43b0b7

  Copy full SHA for a43b0b7

• fix: PR review

  beltram

  committed
  418c811

  Copy full SHA for 418c811

Commits on Jun 6, 2023

• fix: invalid OID for display name in CSR

  beltram

  committed
  ae63ff7

  Copy full SHA for ae63ff7

Commits on Jul 28, 2023

• fix: access token verification in DPoP challenge. Was previously verifying 'cnf.kid' against backend key whereas it must be against client's key

  beltram

  committed
  024147f

  Copy full SHA for 024147f

• client jwk was there the whole time

  beltram

  committed
  06e08cc

  Copy full SHA for 06e08cc

• print kid for debugging

  beltram

  committed
  e85903a

  Copy full SHA for e85903a

• b64 encode the kid since apparently it wasn't

  beltram

  committed
  644188a

  Copy full SHA for 644188a

Commits on Jul 31, 2023

• fix: use the correct userId format

  beltram

  committed
  1d99127

  Copy full SHA for 1d99127

Commits on Aug 29, 2023

• feat: use latest rusty-jwt-tools branch & verify dpop token api-version

  beltram

  committed
  c0bde61

  Copy full SHA for c0bde61

Commits on Sep 12, 2023

• fix: could not reuse a signing key otherwise it would create in accounts & orders and fail the OIDC challenge. The OIDC challenge was not retryable

  beltram

  committed
  52b2396

  Copy full SHA for 52b2396

• fix: oups

  beltram

  committed
  5cb200f

  Copy full SHA for 5cb200f

• fix: same issue as with oidc challenge

  beltram

  committed
  e92a173

  Copy full SHA for e92a173

Commits on Nov 7, 2023

• fix: add cors headers

  beltram

  committed
  5eb51a0

  Copy full SHA for 5eb51a0

Commits on Nov 16, 2023

• Use R3 root cert in smallstep Docker image

  rohan-wire

  committed
  0f480cb

  Copy full SHA for 0f480cb

Commits on Nov 20, 2023

• feat: remove custom hardcoded OIDC challenge for Google

  beltram

  committed
  7a59cee

  Copy full SHA for 7a59cee

Commits on Nov 21, 2023

• Merge pull request #5 from wireapp/rohan/docker-r3-cert

  Show description for c5ababc
  rohan-wire

  authored
  c5ababc

  Copy full SHA for c5ababc

Commits on Nov 22, 2023

• feat: update the protocol by including team & handle in the client dpop token, verifying the handle in the dpop challenge

  beltram

  committed
  ee2a2e0

  Copy full SHA for ee2a2e0

• build: try fixing chmod issue in docker build

  beltram

  committed
  cf76821

  Copy full SHA for cf76821

• build: disable chmod on r3.crt. Need to come back at it later

  beltram

  committed
  2248ae7

  Copy full SHA for 2248ae7

Commits on Dec 15, 2023

• feat: remove query parameters from OIDC issuerUrl so that it allows us to use it to carry the OAuth ClientId in the Challenge.target field without at the same time undermining the idToken verificat…

  Show description for d93fbbc
  beltram

  committed
  d93fbbc

  Copy full SHA for d93fbbc

• build: cleanup docker build

  beltram

  committed
  7366934

  Copy full SHA for 7366934

Commits on Jan 2, 2024

• feat: try using the new ClientId & Handle format (i.e. plain URIs)

  beltram

  committed
  1b3b925

  Copy full SHA for 1b3b925

• chore: use correct rusty-jwt-tools branch with latest client-id changes

  beltram

  committed
  260228f

  Copy full SHA for 260228f

• dbg

  beltram

  committed
  d9b822f

  Copy full SHA for d9b822f

Commits on Jan 5, 2024

• feat: change the separator between user-id & device-id in a client-id. Use '!' instead of ':'

  beltram

  committed
  527b131

  Copy full SHA for 527b131

Commits on Jan 9, 2024

• fix: keyauth was not bound to the id token

  beltram

  committed
  e25e8f3

  Copy full SHA for e25e8f3

Commits on Jan 15, 2024

• inverting oidc claims name & handle just for testing Keycloak, DO NOT MERGE this

  beltram

  committed
  6e5533c

  Copy full SHA for 6e5533c

• remove rusty-jwt-tools branch

  beltram

  committed
  aa0085a

  Copy full SHA for aa0085a