Skip to content

Commit

Permalink
fix: could not reuse a signing key otherwise it would create in accou…
Browse files Browse the repository at this point in the history
…nts & orders and fail the OIDC challenge. The OIDC challenge was not retryable
  • Loading branch information
beltram committed Sep 12, 2023
1 parent c0bde61 commit 52b2396
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions acme/challenge.go
Original file line number Diff line number Diff line change
Expand Up @@ -443,11 +443,13 @@ func wireOIDC01Validate(ctx context.Context, ch *Challenge, db DB, jwk *jose.JSO
return WrapErrorISE(err, "Could not find current order by account id")
}

if len(orders) != 1 {
return WrapErrorISE(err, "There are too many orders for this account for this custom OIDC challenge")
if len(orders) == 0 {
return WrapErrorISE(err, "There are not enough orders for this account for this custom OIDC challenge")
}

if err := db.CreateOidcToken(ctx, orders[0], oidcToken); err != nil {
order := orders[len(orders)]

if err := db.CreateOidcToken(ctx, order, oidcToken); err != nil {
return WrapErrorISE(err, "Failed storing OIDC id token")
}

Expand Down

0 comments on commit 52b2396

Please sign in to comment.