Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(refine-log-filtering) Filter out specific logs #WPB-11179 #21

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

spoonman01
Copy link
Contributor

@spoonman01 spoonman01 commented Sep 19, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Refine log filtering

Causes (Optional)

HTTP client and server had no restriction on what they logged

Solutions

Explicitly avoid logging certain lines


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@spoonman01 spoonman01 changed the title fix(logging-sensitive-data) Filter out logs with sensitive data. fix(logging-sensitive-data) Filter out logs with sensitive data #WPB-11179 Sep 19, 2024
@spoonman01 spoonman01 force-pushed the fix-logging-sensitive-data-v2 branch from f343a52 to cb59d57 Compare September 19, 2024 08:59
Copy link

@spoonman01 spoonman01 changed the title fix(logging-sensitive-data) Filter out logs with sensitive data #WPB-11179 fix(refine-log-filtering) Filter out specific logs #WPB-11179 Sep 19, 2024
@marcoconti83 marcoconti83 merged commit b53c048 into staging Sep 19, 2024
7 checks passed
@marcoconti83 marcoconti83 deleted the fix-logging-sensitive-data-v2 branch September 19, 2024 10:15
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants