chore: replace instant with web-time [WPB-14399] #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instant is no longer maintained the recommended alternative is web-time.
typfel
force-pushed
the
chore/replace-instant
branch
from
219f6f8 to
be490e5
Compare
SimonThormeyer
approved these changes
Dec 16, 2024
coriolinus
approved these changes
Dec 16, 2024
.github/workflows/coverage.yml
Outdated
Comment on lines
15
to
20
| - uses: dtolnay/rust-toolchain@nightly | ||
| with: | ||
| components: rustc, rust-std, cargo, llvm-tools, llvm-tools-preview | ||
| - uses: baptiste0928/cargo-install@v3 | ||
| with: | ||
| toolchain: nightly | ||
| crate: grcov |
There was a problem hiding this comment.
👍🏻 makes perfect sense switching this to nightly instead of master. But then why bring in a separate action for the installer?
- run: cargo install grcovshould do the same thing, more simply.
typfel
force-pushed
the
chore/replace-instant
branch
from
3e74978 to
d8ab0fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
instant is no longer maintained the recommended alternative is web-time.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.