Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make RwLock in RustCrypto async [WPB-10044] #98

Draft
wants to merge 2 commits into
base: wire/stable
Choose a base branch
from

Conversation

SimonThormeyer
Copy link


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

See PR title and corresponding Jira item

Issues

Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added the size/m label Jul 8, 2024
@SimonThormeyer SimonThormeyer marked this pull request as draft July 8, 2024 08:06
@SimonThormeyer SimonThormeyer force-pushed the simon/fix/WPB-10044-Make-RwLock-in-RustCrypto-async branch 2 times, most recently from 7df1c0f to 651d930 Compare July 8, 2024 08:25
@github-actions github-actions bot added size/l and removed size/m labels Jul 8, 2024
@SimonThormeyer SimonThormeyer force-pushed the simon/fix/WPB-10044-Make-RwLock-in-RustCrypto-async branch 3 times, most recently from fbc1a6a to a694c14 Compare July 8, 2024 12:41
@SimonThormeyer SimonThormeyer force-pushed the simon/fix/WPB-10044-Make-RwLock-in-RustCrypto-async branch from a694c14 to aa39a39 Compare July 8, 2024 12:56
@github-actions github-actions bot added size/xl and removed size/l labels Jul 8, 2024
Copy link

github-actions bot commented Jul 8, 2024

This PR is so big! Please, split it 😊

Copy link

github-actions bot commented Jul 8, 2024

This PR is so big! Please, split it 😊

1 similar comment
Copy link

github-actions bot commented Jul 9, 2024

This PR is so big! Please, split it 😊

@SimonThormeyer SimonThormeyer force-pushed the simon/fix/WPB-10044-Make-RwLock-in-RustCrypto-async branch from 2e210da to ebec7d7 Compare July 9, 2024 13:11
Copy link

github-actions bot commented Jul 9, 2024

This PR is so big! Please, split it 😊

@SimonThormeyer SimonThormeyer force-pushed the simon/fix/WPB-10044-Make-RwLock-in-RustCrypto-async branch from ebec7d7 to 9e6880d Compare July 9, 2024 13:16
Copy link

github-actions bot commented Jul 9, 2024

This PR is so big! Please, split it 😊

@echoes-hq echoes-hq bot added the echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. size/xl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant