forked from openmls/openmls
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make RwLock in RustCrypto async [WPB-10044] #98
Draft
SimonThormeyer
wants to merge
2
commits into
wire/stable
Choose a base branch
from
simon/fix/WPB-10044-Make-RwLock-in-RustCrypto-async
base: wire/stable
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
fix: make RwLock in RustCrypto async [WPB-10044] #98
SimonThormeyer
wants to merge
2
commits into
wire/stable
from
simon/fix/WPB-10044-Make-RwLock-in-RustCrypto-async
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonThormeyer
force-pushed
the
simon/fix/WPB-10044-Make-RwLock-in-RustCrypto-async
branch
2 times, most recently
from
July 8, 2024 08:25
7df1c0f
to
651d930
Compare
SimonThormeyer
force-pushed
the
simon/fix/WPB-10044-Make-RwLock-in-RustCrypto-async
branch
3 times, most recently
from
July 8, 2024 12:41
fbc1a6a
to
a694c14
Compare
SimonThormeyer
force-pushed
the
simon/fix/WPB-10044-Make-RwLock-in-RustCrypto-async
branch
from
July 8, 2024 12:56
a694c14
to
aa39a39
Compare
This PR is so big! Please, split it 😊 |
This PR is so big! Please, split it 😊 |
1 similar comment
This PR is so big! Please, split it 😊 |
SimonThormeyer
force-pushed
the
simon/fix/WPB-10044-Make-RwLock-in-RustCrypto-async
branch
from
July 9, 2024 13:11
2e210da
to
ebec7d7
Compare
This PR is so big! Please, split it 😊 |
SimonThormeyer
force-pushed
the
simon/fix/WPB-10044-Make-RwLock-in-RustCrypto-async
branch
from
July 9, 2024 13:16
ebec7d7
to
9e6880d
Compare
This PR is so big! Please, split it 😊 |
echoes-hq
bot
added
the
echoes: technical-roadmap/technical-debt
More specific category, to highlight Technical Debt being tackled.
label
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
echoes: technical-roadmap/technical-debt
More specific category, to highlight Technical Debt being tackled.
size/xl
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
See PR title and corresponding Jira item
Issues
Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.
Causes (Optional)
Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.
Solutions
Briefly describe the solutions you have implemented for the issues explained above.
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.