Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Full p521 support [WPB-8589] #93

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Conversation

OtaK
Copy link

@OtaK OtaK commented Apr 10, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@OtaK OtaK force-pushed the feat/p521-full-support branch 6 times, most recently from 92f1049 to 5c7c7f4 Compare April 16, 2024 09:53
@github-actions github-actions bot added size/xl and removed size/m labels Apr 16, 2024
Copy link

This PR is so big! Please, split it 😊

@OtaK OtaK requested a review from beltram April 16, 2024 11:08
basic_credential/src/lib.rs Outdated Show resolved Hide resolved
@OtaK OtaK force-pushed the feat/p521-full-support branch from 5c7c7f4 to dff10c7 Compare April 16, 2024 12:14
Copy link

This PR is so big! Please, split it 😊

@OtaK OtaK merged commit 29163fe into wire/stable Apr 16, 2024
47 of 48 checks passed
@OtaK OtaK deleted the feat/p521-full-support branch April 16, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants