Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose processed message's credential with its associated public signature key [WPB-5975] #88

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

beltram
Copy link

@beltram beltram commented Mar 22, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@beltram beltram changed the title feat: expose processed message's credential with its associated publi… feat: expose processed message's credential with its associated public signature key [WPB-5975] Mar 22, 2024
@beltram beltram requested a review from OtaK March 22, 2024 13:48
@beltram beltram self-assigned this Mar 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2024

Codecov Report

Merging #88 (95030b6) into wire/stable (8f9e4a9) will decrease coverage by 0.03%.
The diff coverage is 58.82%.

Additional details and impacted files
@@               Coverage Diff               @@
##           wire/stable      #88      +/-   ##
===============================================
- Coverage        80.86%   80.84%   -0.03%     
===============================================
  Files              173      173              
  Lines            17252    17260       +8     
===============================================
+ Hits             13951    13954       +3     
- Misses            3301     3306       +5     

@@ -357,7 +357,7 @@ pub struct BasicCredential {
identity: VLBytes,
}

#[derive(Debug, Clone)]
#[derive(Debug, Clone, Eq, PartialEq)]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to make sure the equality comparison is constant-time

@beltram beltram requested a review from OtaK March 25, 2024 13:54
@beltram beltram merged commit 945654c into wire/stable Mar 26, 2024
47 of 48 checks passed
@beltram beltram deleted the feat/wpb-5975 branch March 26, 2024 13:22
@echoes-hq echoes-hq bot added the echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants