Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate of Lifetime in KeyPackages only for senders #85

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

beltram
Copy link

@beltram beltram commented Feb 21, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@beltram beltram self-assigned this Feb 21, 2024
@beltram beltram requested a review from OtaK February 21, 2024 10:28
@beltram beltram force-pushed the feat/smart-ln-lifetime-validation branch from a66fc40 to ad095d3 Compare February 21, 2024 10:41
@beltram beltram merged commit 3dd1711 into wire/stable Feb 21, 2024
47 of 48 checks passed
@beltram beltram deleted the feat/smart-ln-lifetime-validation branch February 21, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants