Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: tls_codec 0.4.0 #67

Merged
merged 5 commits into from
Nov 28, 2023
Merged

build: tls_codec 0.4.0 #67

merged 5 commits into from
Nov 28, 2023

Conversation

beltram
Copy link

@beltram beltram commented Nov 27, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

This PR is so big! Please, split it 😊

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2023

Codecov Report

Merging #67 (0e3ead5) into feat/rfc9420 (acfc9b6) will decrease coverage by 3.60%.
The diff coverage is 75.00%.

Additional details and impacted files
@@               Coverage Diff                @@
##           feat/rfc9420      #67      +/-   ##
================================================
- Coverage         84.20%   80.61%   -3.60%     
================================================
  Files               173      172       -1     
  Lines             21563    16949    -4614     
================================================
- Hits              18158    13663    -4495     
+ Misses             3405     3286     -119     

Copy link

This PR is so big! Please, split it 😊

1 similar comment
Copy link

This PR is so big! Please, split it 😊

@beltram beltram force-pushed the build/tls-codec-040 branch from 0e3ead5 to 04d42ea Compare November 27, 2023 14:57
@github-actions github-actions bot added size/m and removed size/xl labels Nov 27, 2023
@beltram beltram force-pushed the build/tls-codec-040 branch from 04d42ea to 0001bdb Compare November 27, 2023 14:58
@beltram beltram requested a review from OtaK November 27, 2023 15:32
@beltram beltram merged commit 3b4b21a into feat/rfc9420 Nov 28, 2023
47 of 48 checks passed
@beltram beltram deleted the build/tls-codec-040 branch November 28, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants