Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WPB-14436] helpful dynamic mapping errors #29

Merged
merged 9 commits into from
Nov 22, 2024

Conversation

fisx
Copy link
Contributor

@fisx fisx commented Nov 21, 2024

Fix a bug because of which invalid input data (no scim userName in a POST payload) triggered an undefined instead of showing a helpful error.

@echoes-hq echoes-hq bot added the echoes: unplanned/support Work items completed to meet a customer or user support request. label Nov 21, 2024
@fisx fisx force-pushed the WPB-14436-helpful-dynamic-mapping-errors branch from b029d2f to df24967 Compare November 21, 2024 20:37
fisx added 2 commits November 21, 2024 21:49
Hack around orphan instance; don't turn warning on and off again.
src/LdapScimBridge.hs Outdated Show resolved Hide resolved
src/LdapScimBridge.hs Outdated Show resolved Hide resolved
@fisx fisx marked this pull request as ready for review November 22, 2024 09:04
@fisx fisx requested review from julialongtin and a team as code owners November 22, 2024 09:04
Copy link
Contributor

@supersven supersven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fisx and others added 2 commits November 22, 2024 10:05
…ynamic-mapping-errors' into WPB-14436-helpful-dynamic-mapping-errors
@fisx fisx merged commit 136fc6a into master Nov 22, 2024
4 checks passed
@fisx fisx deleted the WPB-14436-helpful-dynamic-mapping-errors branch November 22, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned/support Work items completed to meet a customer or user support request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants