WPB-2970 Update dependencies, cleanup, add unit test #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisx
reviewed
Mar 12, 2024
battermann
force-pushed
the
WPB-2970-support-team-roles-in-ldap-scim-bridge
branch
from
fe4cb02 to
fd8ecec
Compare
fisx
approved these changes
Mar 13, 2024
| @@ -0,0 +1,6 @@ | |||
| source-repository-package | |||
| type: git | |||
| location: https://gitlab.com/leif.battermann/tinylog.git | |||
There was a problem hiding this comment.
would be nice to have a link to the upstream PR here so it's easier to check whether we can bump this (not urgent).
| @@ -37,6 +38,7 @@ import qualified Web.Scim.Schema.Meta as Scim | |||
| import qualified Web.Scim.Schema.Schema as Scim | |||
| import qualified Web.Scim.Schema.User as Scim | |||
| import qualified Web.Scim.Schema.User.Email as Scim | |||
| import Prelude | |||
There was a problem hiding this comment.
either use relude as before, but then don't use Prelude from base, or toss relude. both makes no sense.
| it "map displayName userName externalId and email" $ do | ||
| testMapping "George" "george" "george@nodomain" "george@nodomain" | ||
|
|
||
| testMapping :: Text -> Text -> Text -> Text -> IO () |
battermann
changed the title
echoes-hq
bot
added
the
echoes: technical-roadmap/technical-debt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a clean-up PR for https://wearezeta.atlassian.net/browse/WPB-2970