fix: update common protocol resolution (WPB-15191)

[yamilmedina]

WPB-15191 [Android] User can not create or see MLS conversations, when they still have a proteus client registered to their account

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

Resolving protocol for 1:1 was incorrectly taking in consideration teamDefault Protocol

Causes (Optional)

When the migration to MLS is not completed, and I have still valid Proteus clients around. The resolution of these conversations, new or existing, was not possible.

Solutions

Since this was introduced for another bug, that now we are taking care by creating the MLS client at the right moment.
We roll back those lines, see.

• fix(mls): respect default protocol in one-on-one conversation initialisation (WPB-8975) 🍒 🍒 #2787

• GitHub link to other pull request

Testing

Test Coverage (Optional)

• I have added automated test to this contribution

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Test Results

3 346 tests   - 3   3 238 ✅  - 3   5m 41s ⏱️ +13s
  572 suites ±0     108 💤 ±0 
  572 files   ±0       0 ❌ ±0 

Results for commit c3a9970. ± Comparison against base commit 13c44e1.

♻️ This comment has been updated with latest results.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.16%. Comparing base (7f1da82) to head (c3a9970).
Report is 2 commits behind head on release/candidate.

Additional details and impacted files

@@                Coverage Diff                 @@
##           release/candidate    #3208   +/-   ##
==================================================
  Coverage              54.16%   54.16%           
==================================================
  Files                   1250     1250           
  Lines                  36504    36510    +6     
  Branches                3699     3699           
==================================================
+ Hits                   19772    19776    +4     
- Misses                 15302    15303    +1     
- Partials                1430     1431    +1     

Files with missing lines	Coverage Δ
...logic/feature/protocol/OneOnOneProtocolSelector.kt	91.30% <100.00%> (+1.83%)	⬆️

... and 5 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f1da82...c3a9970. Read the comment docs.

[datadog-wireapp]

Datadog Report

Branch report: fix/common-protocol-resolution
Commit report: a7838fd
Test service: kalium-jvm

✅ 0 Failed, 3238 Passed, 108 Skipped, 1m 3.5s Total Time