-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: persist mls conversation when mls disabled [WPB-15149] #3205
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3205 +/- ##
=====================================================
- Coverage 54.16% 54.16% -0.01%
=====================================================
Files 1250 1250
Lines 36504 36508 +4
Branches 3699 3696 -3
=====================================================
+ Hits 19772 19774 +2
- Misses 15302 15306 +4
+ Partials 1430 1428 -2
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 3241 Passed, 108 Skipped, 1m 2.93s Total Time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically looks good, but maybe some tests for that scenario? :)
Co-authored-by: Jakub Żerko <[email protected]>
* fix: fallback to proteus if conversation already present but MLS is default (WPB-15191) (#3200) * fix: fallback to proteus if conversation already present and no common protocol * fix: test coverage * fix: test coverage * fix: Migration message not shown in 1:1 conversations (#3042) * fix: update common protocol resolution (#3208) * fix: mls client init [WPB-15022] (#3178) * fix: secure mls client creation with is mls enabled * fix: dont persist mls conversations when mls is disabled * review improvements * fix: persist mls conversation when mls disabled (#3205) --------- Co-authored-by: Yamil Medina <[email protected]> Co-authored-by: Oussama Hassine <[email protected]>
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
MLS conversations was not saved if MLS was disabled, causing further message migration fail.
Solutions
Instead of not saving MLS conversations we save them but with
GroupState.PENDING_JOIN
state to trigger migration when MLS will be enabled