revert: "fix: do not commit User and Client upserts if nothing has changed [WPB-15055]

[MohamadJaara]

WPB-15055 [Android] Crash when opening connection request from paginated list

…nged WPB-15055 (#3188)"

This reverts commit 4a84b76.

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

it broke login and users data are not updated

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

• GitHub link to other pull request

Testing

Test Coverage (Optional)

• I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[datadog-wireapp]

Datadog Report

Branch report: revert/Revert-fix-do-not-commit-User-and-Client-upserts-if-nothing-has-changed-WPB-15055]-(#3188)-This-reverts-commit-4a84b761b5a0c7078a50881b65a6ad21f47226d8
Commit report: fa4c04e
Test service: kalium-jvm

✅ 0 Failed, 3236 Passed, 107 Skipped, 1m 0.33s Total Time

[github-actions]

Test Results

3 343 tests   - 4   3 236 ✅  - 4   5m 14s ⏱️ -3s
  572 suites ±0     107 💤 ±0 
  572 files   ±0       0 ❌ ±0 

Results for commit f64e30e. ± Comparison against base commit 4a84b76.

♻️ This comment has been updated with latest results.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.14%. Comparing base (4a84b76) to head (f64e30e).

Additional details and impacted files

@@                  Coverage Diff                  @@
##           release/candidate    #3198      +/-   ##
=====================================================
- Coverage              54.16%   54.14%   -0.03%     
=====================================================
  Files                   1250     1250              
  Lines                  36495    36477      -18     
  Branches                3704     3696       -8     
=====================================================
- Hits                   19769    19750      -19     
- Misses                 15296    15298       +2     
+ Partials                1430     1429       -1     

Files with missing lines	Coverage Δ
...lin/com/wire/kalium/persistence/dao/UserDAOImpl.kt	52.14% <100.00%> (-0.76%)	⬇️
...ire/kalium/persistence/dao/client/ClientDAOImpl.kt	75.00% <100.00%> (-2.17%)	⬇️

... and 2 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a84b76...f64e30e. Read the comment docs.